[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add more rules to docs/misra/rules.rst
- To: Stefano Stabellini <stefano.stabellini@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 30 Jan 2023 08:33:34 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5Aodvu8vE3nlooikN1x4cHxGE0HAqcf18LOFNZNQdMc=; b=ODO063cJqjjWC4IxThw5+tdlDIW8OaCDAcLnsCI2RTIBZvMlBpXpkUlYQr5igKl1O6ob1F9McbSVRd/hcrGMWgWEtoeKatAuZSa5GhLvobpYWO3bt4qg6NlsYGGPn+Zrt/SOS3pXFvTcAw2BVJWKyVIwRgaYWpllMmFq0aH+grWaLQSHC7gshoElCWucA24WhQjaXUl3nAutx/B52m6JRTz+QFxnwHZ/xhCkjlY5nTSZ5FS4yM91n1rvYGoMenIIVnFOULy8Z2qEwE3XmFkDhn8a9jgLY/O3rAN6ydfCfBWQNrqQ98Hbf0ZenzS9hWT5A+LLOVs6Sub+eNNe86SV7w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YNYvQMmIThtSou8HfZF1AVZ8YHGm88eSxpG3kHjKIx9EDtN+P217AhMFiVElj1XGkWzocAYTxRARQi1gzq737V5mdDm7XrNU07zguF3AWgyIzSpE9jcratPHAdx2e9c+RieTf+q75HoYQKgtZYsrUFrwA7TEC0oR4RUAK7IyPnFLiarWTKJcXtQTajcvxCTSPKCRgRABk/p+9GzoL8RMbmqVZws84M2ED8by+/reOOK4DjUv2IQPG/8aD6glGujiEteofrg0C8s98zTyzGMlonls8OIuypHeudUCMYDtZ+KiVuptf9ajKsA223NsklEvgUynMImTRe5loXBVBX860w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, george.dunlap@xxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, roger.pau@xxxxxxxxxx, Bertrand.Marquis@xxxxxxx, julien@xxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 30 Jan 2023 07:33:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 27.01.2023 19:33, Stefano Stabellini wrote:
> On Fri, 27 Jan 2023, Jan Beulich wrote:
>> On 26.01.2023 19:54, Stefano Stabellini wrote:
>> Looking back at the sheet, it says "rule already followed by
>> the community in most cases" which I assume was based on there being
>> only very few violations that are presently reported. Now we've found
>> the frame_table[] issue, I'm inclined to say that the statement was put
>> there by mistake (due to that oversight).
>
> cppcheck is unable to find violations; we know cppcheck has limitations
> and that's OK.
>
> Eclair is excellent and finds violations (including the frame_table[]
> issue you mentioned), but currently it doesn't read configs from xen.git
> and we cannot run a test to see if adding a couple of deviations for 2
> macros removes most of the violations. If we want to use Eclair as a
> reference (could be a good idea) then I think we need a better
> integration. I'll talk to Roberto and see if we can arrange something
> better.
>
> I am writing this with the assumption that if I could show that, as an
> example, adding 2 deviations reduces the Eclair violations down to less
> than 10, then we could adopt the rule. Do you think that would be
> acceptable in your opinion, as a process?
Hmm, to be quite honest: Not sure. Having noticed the oversight of the
frame_table[] issue makes me wonder how much else may be missed in this
same area (18.1, 18.2, and 18.3).
Jan
|
