[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/6] tools: Introduce a non-truncating xc_xenver_extraversion()


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Mon, 30 Jan 2023 18:06:28 +0000
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "Juergen Gross" <jgross@xxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Edwin Torok <edvin.torok@xxxxxxxxxx>, Rob Hoes <Rob.Hoes@xxxxxxxxxx>
  • Delivery-date: Mon, 30 Jan 2023 18:06:52 +0000
  • Ironport-data: A9a23:FiTmoaxzsShjXMvpxG16t+cBxirEfRIJ4+MujC+fZmUNrF6WrkUFy TEeXW6FMv/ZZmfwKo8iOdi29x9T7MLdz4Q2TgE9ryAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UwHUMja4mtC5QRnPqgT5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KUd2q ucdEWsWVy2Si7icmKCKEMtijMt2eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKZOUYn1lQ/UfrSmM+hgGX/dDtJ7kqYv6Mt70DYzRBr0airO93QEjCPbZQJzh/G/ zyZl4j/KhsUO9W9yzaLyyKxhc7XgiDfXaIAPZTto5aGh3XMnzdOWXX6T2CTrfCnh2akVtlYK khS/TAhxYA77EGxR8PxdwG5qnWD+BUbXrJ4A+A8rQ2A1KfQywKYHXQfCC5MbsQ8s807TiBs0 UWG9/vrCiZoq6a9Um+G+/GfqjbaETcRBX8PY2kDVwRt3jX4iNht1FSVFI8lSfPryISvQlkc3 gxmsgAYv+oIiPdQzJyG7FydqWq+l8LrQAQ6s1C/sn2e0it1Y4usZoqN4Ffd7OpdIIvxcmRtr EToiODFsrlQUMjleDilBbxUQer3v6rt3Cj02wYHInU3y9i6F5dPl6h06So2GkpmO91sldTBM B6K4lM5CHO+0RKXgU5Lj2CZUZ9CIUvIT46NuhXogj1mP/BMmPevpn0GWKJp9zmFfLIQua8+I 4yHVs2nEGwXD69qpBLvGbhAieZ0n3BinTKMLXwe8/hA+ePODEN5tJ9faAfeBgzHxPzsTPrpH yZ3aJLRlkQ3vBzWaSjL648DRW3m3lBiba0aX/d/L7bZSiI/QTFJNhMk6e95E2CTt/gPx7igE 7DUchMw9WcTclWccF7SMysyNeqHsFQWhStTABHA9G2AgxALCbtDJo9GH3frVdHLLNBe8MM=
  • Ironport-hdrordr: A9a23:77ZirquTaLyRMkqvfp2etxwL7skCq4Aji2hC6mlwRA09TyXGra +TdaUguSMc1gx9ZJh5o6H8BEGBKUmskKKdkrNhQYtKPTOW81dASbsN0WKM+UyYJ8STzJ8/6U 4kSdkFNDSSNykxsS+Z2njBLz9I+rDum8rI5ds2jU0dNj2CAJsQizuRfzzrdHGeMzM2YqbReq DshPZvln6FQzA6f867Dn4KU6zqoMDKrovvZVorFgMq8w6HiBKv8frfHwKD1hkTfjtTyfN6mF K13zDR1+GGibWW2xXc32jc49B/n8bg8MJKAIihm9UYMTLljyevfcBEV6eZtD44jemz4BIBkc XKoT0nI8NvgkmhM12dkF/I4U3NwTwu43jtxRuzmn34u/H0Qzo8Fo5omZ9ZWgGx0TtvgPhMlI Zwm06JvZteCh3N2A7n4cLTah1snk2o5VI/jO8oiWBFW4d2Us4RkWVfxjIULH4zJlO51GkVKp gqMCga3ocTTbquVQGbgoCo+q3qYp18JGbBfqFIgL3r79EfpgEG86Jf/r1Rol4wsKsnTZ9K/u LFNbktuo1vY6YtHPpALdZEeNCwDGPVRxLKLSa1GnTIUI86G1+lke+v3F0SjNvaIqDgCKFCw6 jpQRdWs3U/dFnpDtDL1JpX8grVSGH4Rjj1zNpCjqIJzIEUaYCbRRFrcmpe5PeIsrEaGInWSv yzMJVZD7vqKnbvA59A20n7V4NJIXcTXcUJspJjMmj+6v7jO8nvrKjWYfzTLL3iHXItXX7+GG IKWHz2KN9b5k6mV3fkiFzaWm/reEb44ZVseZKqttQ72cwILMlBowIVgVO26oWCLiBDqLU/eA 9kLLbugsqA1ByLFKbznhdU0zZmfzVoCe/bIgJ3TCcxQjPJTYo=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Jan 17, 2023 at 01:53:32PM +0000, Andrew Cooper wrote:
> ... which uses XENVER_extraversion2.
> 
> In order to do sensibly, use manual hypercall buffer handling.  Not only does
> this avoid an extra bounce buffer (we need to strip the xen_varbuf_t header
> anyway), it's also shorter and easlier to follow.
> 
> Update libxl and the ocaml stubs to match.  No API/ABI change in either.
> 
> With this change made, `xl info` can now correctly access a >15 char
> extraversion:
> 
>   # xl info xen_version
>   4.18-unstable+REALLY LONG EXTRAVERSION
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.