[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86: idle domains don't have a domain-page mapcache
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 31 Jan 2023 10:05:27 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lchttXlb5td7/Pv+1xrYNwaTzv15GP55gP8SAkuZPME=; b=niptkvmsQlQs+s392BU8HXfW/cVW6cIvjTx3535F5eUw+u9KMlnUnhjtD3D2BAzbCrvixHJ73UqOQN1n0tQAa7++vt/v+BAAw67L4RIf3zONTQq7SQMmJuEdRblHuk7bmtZ95DhchVo3ydVwhSgnmLqMjSOOJOsZAQmQPj2ieiBUXcF+V6uBEHOfZmIoFXkhc2yLGCtldZH3IipFzm0kuW/hDIyx7BdO8RP1hAfptRFiJUFfqqGCduGE9vwhGA8XvnuOjSXJ7JE402d7MGh8rAOuvK0C8lCev+8wgYlj8jw7bj3SnbYZMMS/HfZvzxZh14JQZB7k/YQZfWf5zdJz/A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bqqQSxLvoyU8bLA3jQFW/+tbYaxU+N75YQ4o2c18ZCGYCrvOv5OY5NMK+Y6i/oeQ0k+U5daPh+91vQtLZ1t74RbenTrsHqAz/CyPKreynQGfpG/c63Nb4RoHpVJqAw57G0IuUct9W7aOLlmWe1PfLPtUK/rsV97WDop6MrfsAJdNj9V5NHI8x10yZYC42ydWZQWYSsuy1YK/rGZGTAUtsXcDzp4OcuDDtIcdWWrINAosM/ZJ+ikaZk0LMk4DAZKdLvjTGzUqlzKgFtX7HTN5CvvkrpqtHPfGuGrctnqvsjfrqrW2H1xEG4DY7ZNcb9w0vyMVDQP2Pw397Dx8qDv/fA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 31 Jan 2023 09:05:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 30.01.2023 20:00, Julien Grall wrote:
> On 05/01/2023 11:09, Jan Beulich wrote:
>> --- a/xen/arch/x86/domain_page.c
>> +++ b/xen/arch/x86/domain_page.c
>> @@ -28,8 +28,11 @@ static inline struct vcpu *mapcache_curr
>> /*
>> * When current isn't properly set up yet, this is equivalent to
>> * running in an idle vCPU (callers must check for NULL).
>> + *
>> + * Non-PV domains don't have any mapcache. For idle domains (which
>> + * appear to be PV but also have no mapcache) see below.
>> */
>> - if ( !v )
>> + if ( !v || !is_pv_vcpu(v) )
>> return NULL;
>
> I am trying to figure out the implication on this change with my patch
> [1]. Is this expected to go before hand?
The change here may not be necessary at all with your change. The main
reason I sent this patch was to augment my comments on your patch. If
yours gets adjusted to account for the (perhaps just theoretical) issues
(if just theoretical, then description adjustments may be all that's
needed), then I may be able to drop this instead of seeing whether I can
convince myself that some / all of Andrew's requests can actually safely
be fulfilled.
Jan
|
