[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[QEMU][PATCH v5 07/10] hw/xen/xen-hvm-common: Use g_new and error_report


  • To: <qemu-devel@xxxxxxxxxx>
  • From: Vikram Garhwal <vikram.garhwal@xxxxxxx>
  • Date: Tue, 31 Jan 2023 14:51:46 -0800
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A4ErF5BL7bDWql01g8Ddsvo8tfdsJHgWhVo5VZ0Rbpo=; b=YJNZDExdjXVkGI7o9ZE+UJi114bodC53Fr+EV7TTuTM4dIOTsWH6n9YpGMa2SMnoMx2sIc6R9/MXjb8jUpXl/bU83K38JvquPNYNWAQFtEwp1ziagUXr/9AXTQEMFW0EClBg50SOBdLZpzQ528Xd8n1VvVl1sC3hIPOo8c4dsOhl1ZYoeh1vCCoJV8vyw2NSwL+JbFQNrMP9uGzxmREKGVrsgBeJvbXFxzpBMI1S2f7inSZqu92MdhKUFnRKXz9lD+PJCnJwfCGZm7dpxngPCA06h5c5ktbVLmA2uVRMBOZhKuSS4VjDpsA6eeajMMat39P1bzBxFNLUzNgGy/QsGg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mXY2AGIYjpjCP5V5Cx+0Sq7p38NQM1z89S78V/x4yehYjVXBF77UpCm7EJPoowmBcmV4DDG4dj7Ub463DQU1VvX2BjXWv/GPvkFj9XTqL5gZrdhlGSxdYGAb84wnJmy/d315XqYZbTfZ+3/0Kcj/+x3D3LMUOjjtNyyR2Om8m8ebpPUDB7Y1D15g783RPppuz2s7yhRlF7c7Z7KHhTDBL2BcZRvQCnCaPJbtk4mlLJvVtKeFIH8YFrxjFUhjlwyY6N7M+HkUNPMUQzUhRF4CyAV/RrPDBRVCpUudcnDDrE++nIac2u4LUGhsp32SHTLhrHa3oqIEWNv5ybxOAYodLA==
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <vikram.garhwal@xxxxxxx>, <stefano.stabellini@xxxxxxx>, <alex.bennee@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, "Paul Durrant" <paul@xxxxxxx>
  • Delivery-date: Tue, 31 Jan 2023 22:52:48 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Replace g_malloc with g_new and perror with error_report.

Signed-off-by: Vikram Garhwal <vikram.garhwal@xxxxxxx>
Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
---
 hw/xen/xen-hvm-common.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/hw/xen/xen-hvm-common.c b/hw/xen/xen-hvm-common.c
index 5e3c7b073f..077c8dae5b 100644
--- a/hw/xen/xen-hvm-common.c
+++ b/hw/xen/xen-hvm-common.c
@@ -34,7 +34,7 @@ void xen_ram_alloc(ram_addr_t ram_addr, ram_addr_t size, 
MemoryRegion *mr,
     trace_xen_ram_alloc(ram_addr, size);
 
     nr_pfn = size >> TARGET_PAGE_BITS;
-    pfn_list = g_malloc(sizeof (*pfn_list) * nr_pfn);
+    pfn_list = g_new(xen_pfn_t, nr_pfn);
 
     for (i = 0; i < nr_pfn; i++) {
         pfn_list[i] = (ram_addr >> TARGET_PAGE_BITS) + i;
@@ -731,7 +731,7 @@ void destroy_hvm_domain(bool reboot)
             return;
         }
         if (errno != ENOTTY /* old Xen */) {
-            perror("xendevicemodel_shutdown failed");
+            error_report("xendevicemodel_shutdown failed with error %d", 
errno);
         }
         /* well, try the old thing then */
     }
@@ -801,7 +801,7 @@ static void xen_do_ioreq_register(XenIOState *state,
     }
 
     /* Note: cpus is empty at this point in init */
-    state->cpu_by_vcpu_id = g_malloc0(max_cpus * sizeof(CPUState *));
+    state->cpu_by_vcpu_id = g_new0(CPUState *, max_cpus);
 
     rc = xen_set_ioreq_server_state(xen_domid, state->ioservid, true);
     if (rc < 0) {
@@ -810,7 +810,7 @@ static void xen_do_ioreq_register(XenIOState *state,
         goto err;
     }
 
-    state->ioreq_local_port = g_malloc0(max_cpus * sizeof (evtchn_port_t));
+    state->ioreq_local_port = g_new0(evtchn_port_t, max_cpus);
 
     /* FIXME: how about if we overflow the page here? */
     for (i = 0; i < max_cpus; i++) {
@@ -864,13 +864,13 @@ void xen_register_ioreq(XenIOState *state, unsigned int 
max_cpus,
 
     state->xce_handle = xenevtchn_open(NULL, 0);
     if (state->xce_handle == NULL) {
-        perror("xen: event channel open");
+        error_report("xen: event channel open failed with error %d", errno);
         goto err;
     }
 
     state->xenstore = xs_daemon_open();
     if (state->xenstore == NULL) {
-        perror("xen: xenstore open");
+        error_report("xen: xenstore open failed with error %d", errno);
         goto err;
     }
 
-- 
2.17.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.