[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH for-4.17 v6 1/5] libs: Fix auto-generation of version-script for unstable libs
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Mon, 6 Feb 2023 15:52:20 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TO/EOIlXqhwx7p11Bl7KDym+tfvER+7l0E2fOFjUnMs=; b=JMNdBSVdK8IWiqYMVnWvv2ay0JT9BKRA43XHJOImQlJCbKagHMH/x8AACNYVQwhapO67ZslBblw0IBze6URz3P+3Gqlz9VOg92kkkKquGXEFPrFlon7udNt8+dWfMgPQcQih/WlT4edpcGIwgi2VbxWOc5994FRwcFj+Bvr2MRMdVSShd2aBxDOg66U6k1Kzba4n2IVucpCL/0xTbribEh3R+AmEpizTnl9MZAiOSGssaIECEVoZBIrJ5j9nFDCRz/V86xOxoJUC2mA2N6bW3lnfyhMNL5Oc4TkX3Y6TItIR1vEgkkvmvEYWu4XjMutwAUYC32QsjrY2g3UF6pQ7Nw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Iqkmok6GURx0BD6q7jnztJRwPF5/DkSmN72E36K5qKT6PGOAlO5DJrt4sJAWulh1HcNWSBYdUcjhtGJ6XEmu8jxk2yGyhFyEClf5x7E5BIYzvThndq9gX9aOklRfalRfOHhmhUw28zFipWAd0Mf52isZhsZvpJBM0ndP1nCKLx/Uct0ywim6YmVX1ReoQa97dYMmKbOggb1fn+9+c0xWTcXuf2HBvqYHFdxLQRzzPc8JaKQC0P4FqSTXXgKMvNIveTOrzJ2cPthiPG5vDj1/XxN8Z6bTYmoQBSURW/hBICxjj4IEmrn3+NC8ywKmHdTQG3yC1SRH9dZXUHVm5cKK+g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Mon, 06 Feb 2023 15:52:51 +0000
- Ironport-data: A9a23:FPWSsKPzHOv4mYXvrR1/lsFynXyQoLVcMsEvi/4bfWQNrUp30GQFn GtNWmGGbP7YazPyeNgiOYm08xxTu5DcnNZmQQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9Suv3rRC9H5qyo42tC5gJmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0uxZE2wR2 NsVEx82fy+CqP2GzZmjddA506zPLOGzVG8ekldJ6GmFSNoDH9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+vFxvzG7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prr6Rx32gAd9IfFG+3vBbiRqoxkUONDofSkL4u9e21E2+eesKf iT4/QJr98De7neDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJhZDYtE7sM49RRQxy 0SE2djuAFRHsqCRSH+b3qeZq3W1Iyd9BXQZeSYOQA8B4t/iiII+lBTCSpBkCqHdpsLxMSH9x XaNtidWr7ccl8kQzI2g4EvKxTmro/D0ohUd4wzWWiep611/bYv9O4iwswCHtLBHMZqTSUSHs D4cgc+C4esSDJaL0iuQXOEKG7Lv7PGAWNHBvWNS81Aa32zF0xaekUp4u1mS+G8B3h44RALU
- Ironport-hdrordr: A9a23:YXPWfq56u5219POxigPXwMbXdLJyesId70hD6qkRc3Bom6mj/P xG88516faZslgssRMb+exoSZPgfZq0z/cci+Qs1NyZLWrbUQWTXeRfxLqn7zr8GzDvss5xvJ 0QF5SW0eeAb2RHsQ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 20/01/2023 7:44 pm, Anthony PERARD wrote:
> When there isn't a version-script for a shared library (like for
> unstable libs), we create one based on the current Xen version. But
> that version-script became out-of-date as soon as Xen's version
> changes and make as no way to regenerate the version-script on
> rebuild.
>
> For unstable libs, we only needs the symver to be different from a
> previous release of Xen. There's an option "--default-symver" which
> allow to use the soname as symver and as the soname have the Xen
> release version, it will be different for every release. With
> --default-symver we don't need to generate a version-script.
>
> But we also need to know if there's already an existing version script
> , for that we introduce $(version-script) to be used to point to the
> path of the existing script. (Guessing if a version script exist for a
> stable library with for example $(wildcard) won't work as a file will
> exist when building the library without this patch.)
>
> We don't need the version-script unless we are making the shared
> library so it is removed from the "all" target.
>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
