Re: Proposal: List files in Xen originated from external sources

[Jan Beulich <jbeulich@xxxxxxxx>]

On 06.02.2023 22:23, Stefano Stabellini wrote:
> On Mon, 6 Feb 2023, Jan Beulich wrote:
>> On 03.02.2023 20:55, Stefano Stabellini wrote:
>>> On Fri, 3 Feb 2023, Luca Fancellu wrote:
>>>> And then, if the file is not subject to backport and now we “own” the 
>>>> file, there is no more the need to list it
>>>> in the external file, a commit search can reveal when it was converted to 
>>>> Xen codestyle and removed from
>>>> the external file list so we don’t lose the history.
>>>
>>> Yes, I agree. If a file is coverted to Xen coding style and follows
>>> MISRA rules, then there is no need to list the file in
>>> docs/misra/external-files.json.
>>>
>>>
>>>> So we would end up excluding just all the file listed in 
>>>> external-file.json by the analysis.
>>>
>>> Right, I think so too
>>
>> Personally I think this is too focused on Misra.
> 
> We are trying to do two things at once:
> 1) list of external files with their management info (backports, origin, etc.)
> 2) list of files and paths to exclude from MISRA checking
> 
> From this discussion it became clear that 1) and 2) are very different,
> have different requirements, and different info attached. In fact, the
> two lists of files and paths don't even match: not all external files
> exclude MISRA checking and some non-external files also exclude MISRA
> checking.
> 
> I suggest we go forward with a MISRA-only exclude list with files and
> paths to exclude from automatic checking, and without any implication
> about external files. The list could be a json file called
> "misra-exclude.json" to avoid any doubts.

That would be fine with me. Such a file could then include a justification
for each exclusion right away.

Jan