[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/4] Build system: Replace git:// and http:// with https://


  • To: Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 8 Feb 2023 08:02:00 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gY1TRlj8K9y3EEs7dSAdirCHxY/e6l6kQYi59rctxco=; b=PpfhaThunQzjjspN6iUVGyeITOKzqEbddDHwcAhAim+jlk50jBZlmdPhit/XJEfrNfp6b9VdCBm2oOb+OGT8RvO0CWpueGy+DfPI16DoFdS5lsb0RSYab44/6RrNdauOZLSRQKxg9kLuM+7ffZFM8PQwJsWRJId9JD/+bg58QZEosjYaF+PIL8VCZhyqXSxI1ewfH66UuG0xzgGWQlRCAeauXGR4ly3RclTlvyEJvzdOo1ba9m915lJ/NqfHd6EoJY2T6AkF/U7zS1N/ihr9eA9gfzQr0JxAJRYMLwmH85/7oMO5ztVALyDypecAIfArs4BSSTosNXCl+j9ECiqfJQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wsh0GeiA1qZz7MArhe6UPagRq+PB2kk0pPcTf4QrQczRhxtzygcharlyKHx57aSkY2F7WvSW1EgwqzaNge0Cao2GshqrQgs48cuUkvF6dygGsZ3Dj+y6hLVVnJk1XWOgghKfS8Fkkfs3mNPFVJx71cA7LwhllvWwCjJiznluTXPO3EZDok3BFG7HaXEju8tZ8MueoGArhAd4DOOk3pcfNKw+Z02tMNVQk/WfEa2K6n7J1h34arFwMibR5CW1titzgISDXpzD0lpk/RrOC0ZA1hf7ZeBrs2fTdjJ/6KTq3rLd7pRNZr4fNC8PP749bGwZNej3EHbZL9+zNdrXjdEIMw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 08 Feb 2023 07:02:40 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 08.02.2023 05:51, Demi Marie Obenour wrote:
> --- a/stubdom/grub.patches/10graphics.diff
> +++ b/stubdom/grub.patches/10graphics.diff
> @@ -1187,7 +1187,7 @@ diff -Naur grub-0.97.orig/stage2/graphics.c 
> grub-0.97/stage2/graphics.c
>  + *  GNU General Public License for more details.
>  + *
>  + *  You should have received a copy of the GNU General Public License
> -+ *  along with this program; If not, see <http://www.gnu.org/licenses/>
> ++ *  along with this program; If not, see <https://www.gnu.org/licenses/>
>  + */

While this one may be seen as simply on the edge, ...

> --- a/tools/examples/xeninfo.pl
> +++ b/tools/examples/xeninfo.pl
> @@ -36,7 +36,7 @@ sub apiconnect
>  {
>       foreach my $xenhost (keys %xenhosts)
>       {
> -             my $xen = 
> RPC::XML::Client->new("http://$xenhost:$xenhosts{$xenhost}{'port'}");
> +             my $xen = 
> RPC::XML::Client->new("https://$xenhost:$xenhosts{$xenhost}{'port'}");
>               my $session = 
> $xen->simple_request("session.login_with_password", "user","");
>               if (! $session)
>               {

... this pretty clearly isn't part of the build system. And iirc Anthony
had put under question this change anyway.

> --- a/tools/firmware/etherboot/Makefile
> +++ b/tools/firmware/etherboot/Makefile
> @@ -5,9 +5,9 @@ include $(XEN_ROOT)/tools/Rules.mk
>  include Config
>  
>  ifeq ($(GIT_HTTP),y)
> -IPXE_GIT_URL ?= http://git.ipxe.org/ipxe.git
> +IPXE_GIT_URL ?= https://git.ipxe.org/ipxe.git
>  else
> -IPXE_GIT_URL ?= git://git.ipxe.org/ipxe.git
> +IPXE_GIT_URL ?= https://git.ipxe.org/ipxe.git
>  endif

When both URLs are the same now, why keep the ifeq()?

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.