Re: [XEN PATCH for-4.17 v6 5/5] tools: Rework $(xenlibs-ldlibs, ) to provide library flags only.

[Juergen Gross <jgross@xxxxxxxx>]

On 08.02.23 16:10, Anthony PERARD wrote:
> On Wed, Feb 08, 2023 at 08:48:33AM +0100, Juergen Gross wrote:
> > On 20.01.23 20:44, Anthony PERARD wrote:
> > > LDLIBS is usually only the library flags (that is the `-l` flags), as
> > > proposed in GNU make manual, while LDFLAGS would be extra flags such
> > > as `-L`.
> > >
> > > Rework the make macro $(xenlibs-ldlibs, ) to only provide the library
> > > flags. $(xenlibs-ldflags, ) already only provide the extra flags like
> > > the -rpath-link flags.
> > >
> > > Also fix "test_%" recipe in libs/light as "libxenlight.so" in
> > > $(LDLIBS_libxenlight) is been replaced by "-lxenlight". Instead of
> > > just changing the filter, we will start using the $(xenlibs-*,) macro.
> > > For LDFLAGS, we only needs the one for libxenlight, as the one for
> > nit: s/needs/need/
> >
> > > toolcore and toollog are already in $(LDFLAGS), they are dependencies
> > > to build libxenlight.so.
> > I don't like this very much. toolcore and toollog are used directly by
> > the test_% programs, so I don't think we should rely on libxenlight
> > depending on them.
> Ok, I can add them back, it isn't much of an issue to have duplicated
> flags on the command line.
In that case you can add my

Reviewed-by: Juergen Gross <jgross@xxxxxxxx>


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature