[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] x86/svm: cleanup svm.c
- To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 21 Feb 2023 13:14:13 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9/DnHKdozb7q5W/ktgv0Wq2StSDL36ifMJlDECpxKog=; b=BoVjFUJIX8QPUnIxPmtwR77Ts4E+406Tohg5lqpsYqOX1GUYOzi8S9pMfxqc+nxX8WjoPxoud5Ay4tCeeNLRB27WKPZGg5tEaO6P1ulERrqZct/HATWRmQp7gMGl3RGO1g51XRhtbBZlR/yIAEKrcKy9ah3UswrUf38ROw87olXR/MFA2p/dMqFluJWVBco6lEuWeyFyc88sqN29I8pm+naI/HpMMxrAuWhekrmJkreU3JOp4g4C9IMqgLMo9dl01U9+cyG75uC0tfafefVBbDruxX46x1ddjzqRaaCw7Twhk71EE0yRleTBReGtWXJey0zy75d3x0ngLuLJbNkBUw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U6v16eMDoWQPZngPl/bMOWTL2QoaRVa/CwpbMEF9wCf4geGuEUNSWCP5tkksG82bAH3opGWs0MZdM55cSY4/A1jDwmgTOwTp134GyUtHULdOUU17jwM+7pDJstGxIpYOfFPM/v6H58CFCBqxKHW4ebSPu2+QJaahU3f4cfSINKQoRsKqNg6jDSQ2G2NT2aTH76thqB0to1Nty4hcbsZodOpe9Z3LKh07XTVCUKx+ZIwAp8bUjkhd6z7IR277rlH8KM+H4Hh8WeJoNNDFIFqMpX6PD0+hmkn26GHhCnYTd5Fz/hQifQ+hPkb6faE/DoERBtE24FY67PhpLmG+JkP5bg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 21 Feb 2023 13:14:32 +0000
- Ironport-data: A9a23:xvItCKPo5/CFHsTvrR2elsFynXyQoLVcMsEvi/4bfWQNrUomhTVVy GBNWz+AOP+IYmWjfNonaduwoBsH6pODyNIyTQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9Suv3rRC9H5qyo42tC5AVmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0utKHDxl2 dMcEywAcAu7rvKt7pjlbPY506zPLOGzVG8ekldJ6GiASN0BGNXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PRxujeJpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eewnOjBtlDT9VU8NZ3q0WpnTQLAiQXSFyiiMKgj0SyBttmf hl8Fi0G6PJaGFaQZtPgRQ+xpHmIuQEVc9VVGuw+rgqKz8L84QyUG2wFRT5pc8E9uYk9QjlC/ kCNt8PkA3poqrL9YWKQ8PKYoC2/PQARLHQefmkUQA0d+d7hrYovyBXVQb5e/LWdi9T0HXT7x GmMpS1n3rEL15dUjeO84EzNhC+qqt7RVAkp6w7LX2WjqARkeIqiYI/u4l/ehRpdELukopC6l CBss6CjAComV/lhSATlrD0xIYyU
- Ironport-hdrordr: A9a23:X8CFlKs0v4jhSHyEmAnoZ85d7skDzdV00zEX/kB9WHVpmwKj9v xG+85rsyMc6QxhP03I/OrrBEDuex7hHPJOjbX5eI3SPzUPVgOTXf1fBMjZskDd8xSXzJ8j6U 4YSdkBNDSTNzhHZLfBkW2F+o0bsaC6GcmT7I+0854ud3AJV0gH1WhE422gYyhLrWd9a6bRPa Dsl/Zvln6PeWk3cs/+PXUMRe7Fzue77q7OUFopBwMH9ALLtj+j6Kf7Hx+Ety1uKA9n8PMN8X Xljwe83amos+i6xhjAk0ff4o9bgsGJ8KoyOOW8zuYUNxTxgUKTaINtV6bqhkFMnN2S
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 21/02/2023 11:42 am, Xenia Ragiadakou wrote:
>
> On 2/21/23 13:12, Jan Beulich wrote:
>> On 21.02.2023 08:45, Xenia Ragiadakou wrote:
>>> Hi Andrew,
>>>
>>> On 2/21/23 00:12, Andrew Cooper wrote:
>>>> On 17/02/2023 6:48 pm, Xenia Ragiadakou wrote:
>>>>> Do not include the headers:
>>>>> xen/irq.h
>>>>> asm/hvm/svm/intr.h
>>>>> asm/io.h
>>>>> asm/mem_sharing.h
>>>>> asm/regs.h
>>>>
>>>> Out of interest, how are you calculating these? They're accurate
>>>> as far
>>>> as I can tell.
>>>
>>> I do not use a script (at least not a decent one), if that 's the
>>> question :) . I verify that none of the symbols defined or declared in
>>> the header is used in the file including the header.
>>>
>>>>
>>>> Looking at asm/hvm/svm/*, intr.h itself can be straight deleted,
>>>> svmdebug.h can be merged into vmcb.h, and all the others can move into
>>>> xen/arch/x86/hvm/svm/ as local headers. None of them have any
>>>> business
>>>> being included elsewhere in Xen.
>>>
>>> I can send another patch for that.
>>>
>>>>
>>>>> because none of the declarations and macro definitions in them is
>>>>> used.
>>>>> Sort alphabetically the rest of the headers.
>>>>
>>>> Minor grammar point. "Sort the rest of the headers alphabetically"
>>>> would
>>>> be a more normal way of phrasing this.
>>>
>>> I will fix it in v2.
>>
>> I guess this can be adjusted while committing, seeing that ...
>>
>>>>> Remove the forward declaration of svm_function_table and place
>>>>> start_svm()
>>>>> after the svm_function_table's definition.
>>>>>
>>>>> Replace double new lines with one.
>>>>>
>>>>> No functional change intended.
>>>>>
>>>>> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
>>>>
>>>> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>>
>> ... it's otherwise ready to be committed.
>
> Great, thx.
I already committed this patch, with it fixed up, and one other tweak
that we commonly do which is to leave a blank line between different
groups of headers.
It greatly helps people trying to figure out where to put a new header.
~Andrew
|
