[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] x86/MSI: drop "packed" attribute from message data/address structures
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 22 Feb 2023 11:35:37 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5etHIMqI3C7arm6Ep3GLTy1uNN/G7VrBq+eM8Xi+RqM=; b=ISsYA47byBFrO/YT95QVECKqBYYnSqQV4r+vbmR3wL4KhJKrRIzkSst4Aw3vTHHkWQ1CNmEeMdQjdYbvYzlOmFPRTXqO+MvMZdqWhDBuRTbXvKbIb+MIlUQQ/vqFE4ffJuXRhzJdZ64YzSP0XchOWT7v6WckekmcRwYCPdwNGFM1M0XfH2cTRlX6YbF/1OugROvPoy9NVyEjhkVOaqL627MpfXu8Wvwrg6U7zxpQvzKfMpvKz4Ectu1x70L35CLcSs1blEdGYhkbNN87X5K1Uio6NbmvpKeknPTObdyN+72bMCj58uwL7KNsZB55SX5JokWYtvj4fkQJg4wbCOFOjQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FAC0ESwZS6TtArQ6xWJxMV3XzIIT0TJUXBJbrOKGaateULlXv/1xrtL1ZpIO46qp/aMUniPXD5Fwpuha7a3Jvad3BhzeumOf2qTAR/rzap4G8UAYDk1kcwmjYcEPpr3cmpoPClavfvpIqz3fzoz8bAfdSmWUVXUHYz5GtZmER3SRKjmwtArlCLEbozNnhmTBKMELYOpBMxe+h6HfPTmPNaScVIh6h4vmrp9aPdtOe5uPuJ6x5+xZz0LACxYySNT/I/PeaUDmgdHoNrxFBW0g/H1uKw9OkmoDy3yXfBx6jHsFO810ZbuYuwMqB7tsDCL1c+UXcJ6MgU9+cvtEsHqB0Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 22 Feb 2023 10:35:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
The attribute has no purpose here and, in the worst case, could lead to
the compiler generating worse code. In practice, however: No change to
generated code (surprisingly not even to generated debug info), at least
with gcc12 and the .config-s I've tried.
Requested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
--- a/xen/arch/x86/include/asm/msi.h
+++ b/xen/arch/x86/include/asm/msi.h
@@ -178,7 +178,7 @@ int msi_free_irq(struct msi_desc *entry)
* MSI Defined Data Structures
*/
-struct __packed msg_data {
+struct msg_data {
uint32_t vector : 8;
uint32_t delivery_mode : 3; /* 000b: FIXED | 001b: lowest prior */
uint32_t : 3;
@@ -187,7 +187,7 @@ struct __packed msg_data {
uint32_t : 16;
};
-struct __packed msg_address {
+struct msg_address {
union {
struct {
uint32_t : 2;
|
