Re: [XEN PATCH v7 01/20] xen/arm: smccc: add support for SMCCCv1.2 extended input/output registers

[Jens Wiklander <jens.wiklander@xxxxxxxxxx>]

On Thu, Feb 23, 2023 at 3:35 PM Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Jens,
>
> On 22/02/2023 15:32, Jens Wiklander wrote:
> > SMCCC v1.2 [1] AArch64 allows x0-x17 to be used as both parameter
> > registers and result registers for the SMC and HVC instructions.
> >
> > Arm Firmware Framework for Armv8-A specification makes use of x0-x7 as
> > parameter and result registers.
> >
> > Let us add new interface to support this extended set of input/output
> > registers.
> >
> > This is based on 3fdc0cb59d97 ("arm64: smccc: Add support for SMCCCv1.2
> > extended input/output registers") by Sudeep Holla from the Linux kernel
> >
> > The SMCCC version reported to the VM is bumped to 1.2 in order to support
> > handling FF-A messages.
> >
> > [1] https://developer.arm.com/documentation/den0028/c/?lang=en
> >
> > Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> > Signed-off-by: Jens Wiklander <jens.wiklander@xxxxxxxxxx>
>
> One remark here. The tags are usually added chronologically. So your
> signed-off-by should be first.
>
> I am not planning to commit this patch until one of the patch using the
> call is ready. If this happen in this version, then I am happy to fix it
> on commit. Otherwise, please do it in the next version:
>
> Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

Thanks, I'll keep that in mind.

Cheers,
Jens

>
> Cheers,
>
> --
> Julien Grall