[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 2/5] xen/riscv: introduce trap_init()


  • To: Oleksii <oleksii.kurochko@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 1 Mar 2023 11:44:45 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e+4hBedckU6EJTQQsk2Gb6nIN8h+3/yPPQNo/5cKrZw=; b=eLv6jdWT9gGt84aduk3HKG0ok8BwAkXuauyPEeB+OioWYqMvyJG8lk4YsimRKI4G29EzZYWBJ0JAeBJ2QZ0qPehVXW7a2TDNXlz6gEiHx8F0jjALA8ucE4unZJVVP1j/Q1WL5YsBV3EoXl7s0mOKta3SLqXRVEzT4bIM1iuBCLMrsnXK2b3ACjbTeC3Xn/Z+7fpUOk3zz9v1bd/WGd6FZNKdflJjBN8X5hIXdWCMXAxesaeIGLhrTv6q+aM2CBa8dWonymkfprSPvCUjEvz0KlVW/6IWowVT5Cya0IsEmYDOc6qd2lh5NE/p4t55GNa7pknJAb1mlBl+TxKr0LAQgw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bOZ8gJ8YbvTjTrxaYHuX/2UwszN1nE2IZM6vDTS1IuSVWDYTMW51ZLUkx3rd3+FYPwRxuNYv0ay7JIylbI1441+D944s/+MkmjGA0qTuklORZyfX/siT5aw+H9woonJBr8EKZSg/87B5/csMJn1eZJmQxqZ9OVyDI/fLPpbCbITe8GCR4liR3bhZnHGs449ldCdCVyi9CkMbdQlSVx0CWlBWq7tvF7ssjCRgzKBygnXpfcnLORH96kPRcopCOT779wiyAQwCBTHJtTMzjELvMGi3Nnlh033i6m0ak15SF2Qla71iYmDAU9qaRvoEY/NeWgV2EFWK8BZ0DfRulNTJmg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Julien Grall <julien@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Gianluca Guida <gianluca@xxxxxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 01 Mar 2023 10:45:10 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 01.03.2023 11:34, Oleksii wrote:
> On Mon, 2023-02-27 at 13:50 +0100, Jan Beulich wrote:
>> On 24.02.2023 12:35, Oleksii Kurochko wrote:
>>> @@ -11,6 +13,8 @@ void __init noreturn start_xen(void)
>>>  {
>>>      early_printk("Hello from C env\n");
>>>  
>>> +    trap_init();
>>> +
>>>      for ( ;; )
>>>          asm volatile ("wfi");
>>
>> Along the lines of what Andrew has said there - it's hard to see
>> how this can come (both code flow and patch ordering wise) ahead
>> of clearing .bss.
> So should I add the patch with initializatin of bss as a part of this
> patch series?

That or make clear in the cover letter that there is a dependency.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.