Re: [virtio-dev] [RFC QEMU] docs: vhost-user: Add custom memory mapping support

[Alex Bennée <alex.bennee@xxxxxxxxxx>]

Stefan Hajnoczi <stefanha@xxxxxxxxxx> writes:

> [[PGP Signed Part:Undecided]]
> Resend - for some reason my email didn't make it out.
>
> From: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
> Subject: Re: [virtio-dev] [RFC QEMU] docs: vhost-user: Add custom memory
>  mapping support
> To: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> Cc: qemu-devel@xxxxxxxxxx, virtio-dev@xxxxxxxxxxxxxxxxxxxx, "Michael S.
>  Tsirkin" <mst@xxxxxxxxxx>, Vincent Guittot <vincent.guittot@xxxxxxxxxx>,
>  Alex Bennée <alex.bennee@xxxxxxxxxx>,
>       stratos-dev@xxxxxxxxxxxxxxxxxxx, Oleksandr Tyshchenko
>  <olekstysh@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxx, Andrew Cooper
>  <andrew.cooper3@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Sebastien
>  Boeuf
>       <sebastien.boeuf@xxxxxxxxx>, Liu Jiang <gerry@xxxxxxxxxxxxxxxxx>, 
> Mathieu
>  Poirier <mathieu.poirier@xxxxxxxxxx>
> Date: Tue, 21 Feb 2023 10:17:01 -0500 (1 week, 1 day, 1 hour ago)
> Flags: seen, signed, personal
>
> On Tue, Feb 21, 2023 at 03:20:41PM +0530, Viresh Kumar wrote:
>> The current model of memory mapping at the back-end works fine with
>> Qemu, where a standard call to mmap() for the respective file
>> descriptor, passed from front-end, is generally all we need to do before
>> the front-end can start accessing the guest memory.
>> 
>> There are other complex cases though, where we need more information at
>> the backend and need to do more than just an mmap() call. For example,
>> Xen, a type-1 hypervisor, currently supports memory mapping via two
>> different methods, foreign-mapping (via /dev/privcmd) and grant-dev (via
>> /dev/gntdev). In both these cases, the back-end needs to call mmap()
>> followed by an ioctl() (or vice-versa), and need to pass extra
>> information via the ioctl(), like the Xen domain-id of the guest whose
>> memory we are trying to map.
>> 
>> Add a new protocol feature, 'VHOST_USER_PROTOCOL_F_CUSTOM_MMAP', which
>> lets the back-end know about the additional memory mapping requirements.
>> When this feature is negotiated, the front-end can send the
>> 'VHOST_USER_CUSTOM_MMAP' message type to provide the additional
>> information to the back-end.
>> 
>> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
>> ---
>>  docs/interop/vhost-user.rst | 32 ++++++++++++++++++++++++++++++++
>>  1 file changed, 32 insertions(+)
>
> The alternative to an in-band approach is to configure these details
> out-of-band. For example, via command-line options to the vhost-user
> back-end:
>
>   $ my-xen-device --mapping-type=foreign-mapping --domain-id=123
>
> I was thinking about both approaches and don't see an obvious reason to
> choose one or the other. What do you think?

In-band has the nice property of being dynamic and not having to have
some other thing construct command lines. We are also trying to keep the
daemons from being Xen specific and keep the type of mmap as an
implementation detail that is mostly elided by the rust-vmm memory
traits.

>
>> diff --git a/docs/interop/vhost-user.rst b/docs/interop/vhost-user.rst
>> index 3f18ab424eb0..f2b1d705593a 100644
>> --- a/docs/interop/vhost-user.rst
>> +++ b/docs/interop/vhost-user.rst
>> @@ -258,6 +258,23 @@ Inflight description
>>  
>>  :queue size: a 16-bit size of virtqueues
>>  
>> +Custom mmap description
>> +^^^^^^^^^^^^^^^^^^^^^^^
>> +
>> ++-------+-------+
>> +| flags | value |
>> ++-------+-------+
>> +
>> +:flags: 64-bit bit field
>> +
>> +- Bit 0 is Xen foreign memory access flag - needs Xen foreign memory 
>> mapping.
>> +- Bit 1 is Xen grant memory access flag - needs Xen grant memory mapping.
>> +
>> +:value: a 64-bit hypervisor specific value.
>> +
>> +- For Xen foreign or grant memory access, this is set with guest's xen 
>> domain
>> +  id.
>
> This is highly Xen-specific. How about naming the feature XEN_MMAP
> instead of CUSTOM_MMAP? If someone needs to add other mmap data later,
> they should define their own struct instead of trying to squeeze into
> the same fields as Xen.

We hope to support additional mmap mechanisms in the future - one
proposal is to use the hypervisor specific interface to support an
ioctl() that creates a domain specific device which can then be treated
more generically.

Could we not declare the message as flag + n bytes of domain specific
message as defined my msglen?

> There is an assumption in this design that a single
> VHOST_USER_CUSTOM_MMAP message provides the information necessary for
> all mmaps. Are you sure the limitation that every mmap belongs to the
> same domain will be workable in the future?

Like a daemon servicing multiple VMs? Won't those still be separate
vhost-user control channels though?

>
>> +
>>  C structure
>>  -----------
>>  
>> @@ -867,6 +884,7 @@ Protocol features
>>    #define VHOST_USER_PROTOCOL_F_INBAND_NOTIFICATIONS 14
>>    #define VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS  15
>>    #define VHOST_USER_PROTOCOL_F_STATUS               16
>> +  #define VHOST_USER_PROTOCOL_F_CUSTOM_MMAP          17
>>  
>>  Front-end message types
>>  -----------------------
>> @@ -1422,6 +1440,20 @@ Front-end message types
>>    query the back-end for its device status as defined in the Virtio
>>    specification.
>>  
>> +``VHOST_USER_CUSTOM_MMAP``
>
> Most vhost-user protocol messages have a verb like
> get/set/close/add/listen/etc. I suggest renaming this to
> VHOST_USER_SET_XEN_MMAP_INFO.

VHOST_USER_CONFIG_MMAP_QUIRKS?

VHOST_USER_CONFIG_MMAP_TYPE?

>
>> +  :id: 41
>> +  :equivalent ioctl: N/A
>> +  :request payload: Custom mmap description
>> +  :reply payload: N/A
>> +
>> +  When the ``VHOST_USER_PROTOCOL_F_CUSTOM_MMAP`` protocol feature has been
>> +  successfully negotiated, this message is submitted by the front-end to
>> +  notify the back-end of the special memory mapping requirements, that the
>> +  back-end needs to take care of, while mapping any memory regions sent
>> +  over by the front-end. The front-end must send this message before
>> +  any memory-regions are sent to the back-end via 
>> ``VHOST_USER_SET_MEM_TABLE``
>> +  or ``VHOST_USER_ADD_MEM_REG`` message types.
>> +
>>  
>>  Back-end message types
>>  ----------------------
>> -- 
>> 2.31.1.272.g89b43f80a514
>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: virtio-dev-unsubscribe@xxxxxxxxxxxxxxxxxxxx
>> For additional commands, e-mail: virtio-dev-help@xxxxxxxxxxxxxxxxxxxx
>> 
>
>
>
> ----------
>
> [[End of PGP Signed Part]]


-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro