[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/HVM: purge dubious lastpage diagnostic
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 2 Mar 2023 12:14:37 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VrVnOIa3zlwTrc8qgB+Ke13N4aAcz5GJXauOkhrRUVw=; b=MTF4ivsWSfUl0L+i7yk4D7sFrFPlqrn6l8OFPC/PAb25hPI0/ktkp163ehedgCvHzdFFnqW8MuGH1dhzmorPvB1R5zm9M25u/Z+IiB6F0qB0UvLtBe8kidTWxtMopE2s/ljLbwkKJreKqOy9H+CTKqFG/4LlEvbFg6g6FLvNtMDRYHuMd3FA7+9oQINlIfjx2Xe8lNbwTWTCwNwa87IFQ2GbLp32KA0Pa73pEOSE3Q+X5dny2VfAeeb8HCWaHcBjktXYWDIpnm37yYzbN7/BDYviW2CiPEjBsf04shqVn1x9/8k9eQWk66HIECis+Oj6bjgTZtsMeRuEQC/cbTdFzQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jNmP+b8sXaWmTb/Z8wr24+2XUf2IOEgtFfyJFsbmqCH22O53MbXSdLTy3cdE2o0mdNvb4Moi+NVVE4iGWZbFgXncACpW27Fy2A4LFVTgtTERKIRgSUM/hu3VCNhaSCuu9TftdQxdJv8M7pHj8htDxTYCAx1s6omLV+T23xKNOLqIftfnK/DQecgbEY/5xBQAYiamEpD2MU8WN5l40WYOtlgG7QyS7JCmZ8OsDQfF6gAaXv9ICFrjEcyc6jyaI2+b9MfcPmZncL/Cq3rLOPjwKcgB2/hZzo4tgfyL3D3ItsG9/BIP+2txX6Efp49qfmup77kOlQ1EUNqK9yPOiqEgRw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Thu, 02 Mar 2023 12:14:55 +0000
- Ironport-data: A9a23:af8ukKrJLPg8WR3O8BzofyL41YNeBmI6ZBIvgKrLsJaIsI4StFCzt garIBnTb/mDNDbwLdB3OYXl8hxSuZ6DzddjSQtlrSwzFCIb95uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WNwUmAWP6gR5weFzyNNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAApTcgmzwP+W+bjlQ/A0wfwgdvv0EJxK7xmMzRmBZRonabbqZvyQoPV+jHI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeWraYSFEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXpp6Y62AzLnAT/DjU7TniZrsiZqXeERpVfO lA9wgFy9YULoRnDot7VGkfQTGS/lhwWVsdUEuY6wBqQ0aeS6AGcbkAUQzgEZNE4ucseQT0xy kTPj97vHSZosrCeVTSa7Lj8hSy2ETgYKykFfyBscOcey9zqoYV2hBSfSN9mSfSxloesR2G2x C2Wpi8jgblVldQMy6iw4VHAhXSru4TNSQk2oA7QWwpJ8z9EWWJsXKTwgXCz0BqKBNzxooWp1 JTcp/Wj0Q==
- Ironport-hdrordr: A9a23:LoiaIq8BZ1EPqDXX3+Zuk+DhI+orL9Y04lQ7vn2ZKCYlC/Bw8v rFoB11726QtN98YgBDpTnEAtjifZq+z/9ICOsqTNOftWDd0QPCEGgh1+vfKlbbakrDH4BmpM FdmmtFZOEYz2IWsS832maF+h8bruW6zA==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 02/03/2023 12:06 pm, Jan Beulich wrote:
> Quoting b5d8b03db136 ("x86/shadow: Drop dubious lastpage diagnostic"):
>
> "This is a global variable (actually 3, one per GUEST_PAGING_LEVEL), operated
> on using atomics only (with no regard to what else shares the same
> cacheline),
> which emits a diagnostic (in debug builds only) without changing any program
> behaviour.
>
> It is presumably left-over debugging, as it interlinks the behaviour of all
> vCPUs in chronological order. Based on the read-only p2m types, this
> diagnostic can be tripped by entirely legitimate guest behaviour."
>
> All the same applies here (it's only a single variable of course).
Just "The same ..."
It's not all, because of the single variable note, but grammatically
speaking its fine without the "All".
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
I was aware of, but had forgotten, that we had this pattern elsewhere.
|
