[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v7 07/20] xen/arm: ffa: add defines for framework direct request/response messages


  • To: Jens Wiklander <jens.wiklander@xxxxxxxxxx>
  • From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Date: Fri, 3 Mar 2023 08:14:09 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/IjNJZrJLmlbrvK+o7KPdBRR8E8Q2HwCwx530626NJs=; b=gdNVN5//MFbIPxiRL8YToOZfWF4qiD+tJOpKSJ/gpkGXoEt1EjzKcoC3R2uHEWODLEzho5InYanhDBHJtWwLsQWKg0WNxLGNVCEN6w4yN64JVGHHFXWLCKfnXNMP7UFEXJlqyjSIuXZBOjpjBgVSzGZWwL+CI86jiS1ZEEuZwyvigMZQhLLJNSnMKc2wZOQEborVm7MDVVId6GvTS/H/kn360y6/+ahvG8efVzNTfHjuXLrtn8CKSBAR9LYKyszpGK9/kizlEcVWQX3IlxeaJDAaY83wP+afXbrc7f33BTq1BzonBcUmCxzdnJ14g+zmmZzgAhYRx/I4qkktfiOEEA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HuRo1oEfwmOh3aJrQvPdrpj9XUSxXbpiUn4SNaRiCrPl3sk8/LUOdr1MA/j+czL8TvhIU+iO+sJKTDxOvoZy0Pt2p7blxBwdw55B5loZaF/poDvv5SC/k/Q0ldyh1ygQCfvgmFc+YRqdUG0UOTzMkyMS24szXEeaaSD+Mx92e0W7iRfSivdxjXPJDUQJLg28KpwgqIhW/J68HAYMfgy6JPVViMF1FO1D4pCuBbXV/QNc016gtkGT0n6RNJ1ncQ7q5mCIvIQEhWGuJmDfFVYjaQswQpE+n68sEPeWTckgcJsdr0yUHweRsd33xlBJSk3FZbddX9ldyNgiCRUHw28EPA==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Marc Bonnici <Marc.Bonnici@xxxxxxx>, Achin Gupta <Achin.Gupta@xxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
  • Delivery-date: Fri, 03 Mar 2023 08:14:26 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHZRtMc9l4FLuQsA0eLhPi3rXVDQK7d2fAAgArUXQCAABRDgA==
  • Thread-topic: [XEN PATCH v7 07/20] xen/arm: ffa: add defines for framework direct request/response messages

HI Jens,

> On 3 Mar 2023, at 08:01, Jens Wiklander <jens.wiklander@xxxxxxxxxx> wrote:
> 
> Hi Bertrand,
> 
> On Fri, Feb 24, 2023 at 10:39 AM Bertrand Marquis
> <Bertrand.Marquis@xxxxxxx> wrote:
>> 
>> Hi Jens,
>> 
>>> On 22 Feb 2023, at 16:33, Jens Wiklander <jens.wiklander@xxxxxxxxxx> wrote:
>>> 
>>> Adds defines for framework direct request/response messages.
>>> 
>>> Signed-off-by: Jens Wiklander <jens.wiklander@xxxxxxxxxx>
>>> ---
>>> xen/arch/arm/tee/ffa.c | 9 +++++++++
>>> 1 file changed, 9 insertions(+)
>>> 
>>> diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c
>>> index f4562ed2defc..d04bac9cc47f 100644
>>> --- a/xen/arch/arm/tee/ffa.c
>>> +++ b/xen/arch/arm/tee/ffa.c
>>> @@ -56,6 +56,15 @@
>>> #define FFA_MY_VERSION          MAKE_FFA_VERSION(FFA_MY_VERSION_MAJOR, \
>>>                                                 FFA_MY_VERSION_MINOR)
>>> 
>>> +/* Framework direct request/response */
>> 
>> In the previous patch you were more verbose in the comment which was nice.
>> I would suggest here to use the same "format":
>> 
>> Flags used for the MSG_SEND_DIRECT_REQ/RESP:
>> BIT(31): Framework or partition message
>> BIT(7-0): Message type for frameworks messages
> 
> OK, I'll update.
> 
>> 
>>> +#define FFA_MSG_FLAG_FRAMEWORK          BIT(31, U)
>>> +#define FFA_MSG_TYPE_MASK               0xFFU;
>> 
>> Maybe more coherent to name this FFA_MSG_FLAG_TYPE_MASK ?
> 
> This is a balancing act, in this case, I don't think that adding FLAG_
> helps much.

Agree you can remove flag.

> 
>> 
>> I am a bit unsure here because we could also keep it like that and just
>> add _TYPE to other definitions after.
>> 
>> What do you think ?
> 
> I think the defines are long enough as they are.

Right.

Cheers
Bertrand

> 
> Cheers,
> Jens
> 
>> 
>>> +#define FFA_MSG_PSCI                    0x0U
>>> +#define FFA_MSG_SEND_VM_CREATED         0x4U
>>> +#define FFA_MSG_RESP_VM_CREATED         0x5U
>>> +#define FFA_MSG_SEND_VM_DESTROYED       0x6U
>>> +#define FFA_MSG_RESP_VM_DESTROYED       0x7U
>>> +
>>> /*
>>> * Flags used for the FFA_PARTITION_INFO_GET return message:
>>> * BIT(0): Supports receipt of direct requests
>>> --
>>> 2.34.1
>>> 
>> 
>> Cheers
>> Bertrand



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.