[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] xen: update CONFIG_DEBUG_INFO help text
- To: Juergen Gross <jgross@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 7 Mar 2023 11:41:49 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vot0JgLF/0I33rTC1XX1SQO2E/iURNot1FQyTzig7xs=; b=H8FZdQAw9BYDvVDgSPoThVZXzIilBaw1sHRDo8gsuGj1UmenNCj8xf7f0WtA4HzrbML+N7sFPifxKwsPLbDTxyq82WkNJDyvPh8IkNW7YrpxH6eVzAwAFg2z8GfmGZdZbctCabxaMwB285Oil6gnUosHi+derFKPYPg346P0kdrTbTP9ouliiWzzArc/1EMdEcvo7+lGTHjRu7N5ZOlpF+xvPfMO9a9q7ajwC7+mX05cGJml/MHjzWKaefFIwoBXUDO3rWQx3MPMurvfq8OheLAwHZWjtSoplFGoNkRbQL0iLGAMEqkGGi1psdbCMEHKjYUC52DqnOY1ke93IsiFww==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DZiE/b+17TCtp/z+F8emLLGZPFR56ibsQBorijd4Lx0QrFzk7KL1pIs59Z410kV2FbYcq2jnfK1rXjPby1Gxyif+Yi/Y4lidPj2luML5BIagFnyAi5jrONRdv/kb+c6nQ5IgooTWxzBrtxYQcvZAG/6hmM+mlyOR6T+KVmMNw2Zu6ZwmeehUibOjZ4p98NfNgXC6y5UYgxwhwxRcGfiynaJP3DRlHGN5bRGGMpgEFqS7HJdIuxrEIq8dvFPpM7MKzEYJh29gLn8IbIS4cXdS1MrokNR6FfRvWJzUejfN7z52UNIUyltOi/VkXrTGhxRKfQnIr4ID+4+9+VdstgYW5w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 07 Mar 2023 10:42:04 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 07.03.2023 07:32, Juergen Gross wrote:
> --- a/xen/Kconfig.debug
> +++ b/xen/Kconfig.debug
> @@ -15,8 +15,11 @@ config DEBUG_INFO
> bool "Compile Xen with debug info"
> default DEBUG
> ---help---
> - If you say Y here the resulting Xen will include debugging info
> - resulting in a larger binary image.
> + Say Y here if you want to build Xen with debug information. This
> + information is needed e.g. for doing crash dump analysis of the
> + hypervisor via the "crash" tool.
> + Saying Y will increase the size of xen-syms and the built EFI
> + binary.
Largely fine with me, just one question: Why do you mention xen-syms by
name, but then verbally describe xen.efi? And since, unlike for xen-syms,
this affects the installed binary actually used for booting (which may
be placed on a space constrained partition), it may be prudent to
mention INSTALL_EFI_STRIP here (as a way to reduce the binary size of
what ends up on the EFI partition, even if that wouldn't affect the
"normal" way of putting the binary on the EFI partition - people would
still need to take care of that in their distros).
I guess this size aspect wrt the EFI partition is actually something
that should also be mentioned in patch 1, because this can be an argument
against exposure of the option (precisely because it requires extra
activity to prevent the EFI partition running out of space).
Jan
|
