[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [RFC PATCH v1 07/25] hw/xen: Implement core serialize/deserialize methods for xenstore_impl
On 07/03/2023 16:39, Paul Durrant wrote: On 07/03/2023 16:33, David Woodhouse wrote:On Thu, 2023-03-02 at 15:34 +0000, David Woodhouse wrote:From: David Woodhouse <dwmw@xxxxxxxxxxxx> In fact I think we want to only serialize the contents of the domain's path in /local/domain/${domid} and leave the rest to be recreated? Will defer to Paul for that. Signed-off-by: David Woodhouse <dwmw@xxxxxxxxxxxx>Paul, your Reviewed-by: on this one is conspicuous in its absence. I mentioned migration in the cover letter — this much is working fine, but it's the PV back ends that don't yet work. I'd quite like to merge the basic serialization/deserialization of XenStore itself, with the unit tests.The patch is basically ok, I just think the serialization should be limited to the guest nodes... filtering out those not owned by xen_domid would probably work for that.Perhaps we can also set TYPE_XEN_DEVICE or TYPE_XEN_BLOCK_DEVICE to be unmigratable? Ideally I think we want TYPE_XEN_DEVICE to be unmigratable by default *unless* the specific device class (including net and other as we port them from XenLegacyDevice) says otherwise.Yes, that sounds like a good idea.Is there a way to do that?Not something I've looked into. I'll go look now. Maybe calling migrate_add_blocker() in the realize method is the right way to achieve this? Paul
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |