[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] build: run targets cscope,tags,... using tree-wide approach
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 8 Mar 2023 12:10:35 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+NR463oiHKqzcT7wbiZYWcVQzzob4Lnx9iW3z9sgm2c=; b=N8z0VhV15t/yjRqf1E+41CZdsIXYcIRL8VCD50bHBfCcHT0DRQJMYjkWq3FEAsyCNH+GvOGpqt7C1E/8q6dkFlpbFHNv81o8Ol7kHiJYtCTC81b1S3RbtB43A9DL/Z2DUDUnye+AcJ82XO5KrP2xQIVVlnu6fKUJi7sSSZgoKbLk0tPK8eIG7zzM41t4qDiEgAfyKGETECBRqZI33N9IjiQMvFgqyTn+pGM7AJelNy7BSM/gqhAI0J5kg13hwKcV0XfB1ifqcko07OkgUR08ad5RDKFSgAz0s8x7vUbwjJjtx9Q3f+o94bGFnw6yGYeleh+DVBvJHX5eDIbyguxJdg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=daSbMCFt3/O2wuYAa0C/rz+cROKxdry+hx6ZKBQt1ide0WSD3eJ8s7SNONrulHNF2nZfTrfI/0rXTPPpZlypac29YTgUlU2Me+poXsjbdgB2Fb52woxI+tEMo6/O38yEt+Jtezms2ordNRRNf4mBWX5gSq12PUoiYtvmy0n5W5z2Zfs2KFVcVnh3XrgNwtE5Qw5k1FUIoN9pnQIyK12o35zRoyRxh8cPeI0/iPfaD+98Abgh1KpW2hmRIBwWaZDCgbRrHtf6EVFqbNLtZceiNLXTALkHGTEhsxb0XJ6nYKgFe227I7L4CuV6EdpKsjvoz+RgtAFIJvtKb2NXf4lmCw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 08 Mar 2023 11:10:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08.03.2023 11:49, Michal Orzel wrote:
> Despite being a matter of taste, in general, there are two main approaches
> when dealing with code tagging: tree-wide, where all the sources are taken
> into account or config-wide, when considering Kconfig options and actually
> built files. At the moment, all_sources variable is defined using SUBDIRS,
> which lists all the directories except arch/, where only $(TARGET_ARCH)
> is taken into account. This makes it difficult to reason about and creates
> fuzzy boundaries being a blocker when considering new directories that
> might be config-dependent (like crypto/ which is missing in SUBDIRS).
>
> For now, switch to the intermediate solution to list all the directories
> in SUBDIRS without exceptions (also include crypto/). This way, the
> approach taken is clear allowing new directories to be listed right away
> without waiting to fix the infrastructure first. In the future, we can
> then add support for config-wide approach.
>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
|
