[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests/vpci: install test
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Fri, 10 Mar 2023 14:38:15 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7CvgI2n22wGaHGAoxJQbkgrnr1KdMufzybL2RMG/UuY=; b=WWTwppYtZCdqCw22Kt7X6+igp/FMD5RMPGr4sk1LF6eBpFLVAa5Z9i98rU+Bms6dAAqvgFXizlHvq5+51GWHJ1iGaZ/nr4/PQDKzgGF2Liacym3JrB2UpDTcMBegW8/jXutFzQTtRpjwrpd/BvuP5/Sd6+xElS9gSGCMB7O8LX6IQu8iybZ8BwOpPhbdsNkYCeC/YklQsJKcCYq1ooP5Td3bpGGzrD08un97qQF3ixOES3eLxU3y/7Sg/qm/CFuhY+xEsKmltZ7Edy7bWXkasSQJfZiI/Ytbu8P9pyvcOPxep4ZsqSIPIxVxyBqZZ4tiitISI+iQX/nD0EZQ9s4ccg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KjEzO0iySQ9lV/hRRfpcssIIHlaLscwtj6/U6j5SPSiU0kPny8c9EfPy1LXB6KnX8uYTSVQrPLca1dEkCHF3ztPUvNOD0G4bI39opYqPy4B6l1mcDvBYbM8vD1bIYwlP/msg0rqy5/HGUBdMpUbppRqwFZXT/2+wIolvz6uCxrPls3d8u7Y7TPMY8XwlyZRfJTpR71GIevMsZOzyD8wS76E40quKjlMxDrOtOzXBImHzMkUypm9wqjtsQgSYZSUHZOXv45K7Ng1lJbrhXWqMmwxrhOzF2vJMdWZuE91U8AmdLv22KVYo/t/73imWLzvE+tdFni7W00Zz/d8jW22gew==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: andrew.cooper3@xxxxxxxxxx, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 10 Mar 2023 13:38:50 +0000
- Ironport-data: A9a23:Yc+nXq9Rj1vbRTBNB8BbDrUDpn+TJUtcMsCJ2f8bNWPcYEJGY0x3z mBJWmnXPfqOYTT2c9x2bIq0phgG6MCDztRjSwplrXs8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI/1BjOkGlA5AdmPqkT5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklo3 OUiEQgPdiqTgsOGmZmUVbhw3u88eZyD0IM34hmMzBn/JNN/G9XvZvuP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWCilUujNABM/KMEjCObd9SkUuC4 HrP4kzyAw0ANczZwj2Amp6prraXxXmhA99PTdVU8NZmvkKywE0wVyQKVEq5sOPnoEGOS9Nmf hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmSzoLE7gDfAXILJhZRZdpjuMIoSDgC0 l6Sg8ivFTFpqKeSS3+W6vGTtzzaBMQOBWoLZCtBQQ5b5dDm+ds3lkiWEYolF7OphNroHz222 yqNsCU1m7QUi4gMyrm/+lfExTmro/AlUzII2+keZUr9hisRWWJvT9XABYTzhRqYELukcw==
- Ironport-hdrordr: A9a23:UkQsTq2I7WPJ+utokRKUmQqjBHYkLtp133Aq2lEZdPU0SKGlfq GV7ZEmPHrP4gr5N0tOpTntAse9qBDnhPxICOsqXYtKNTOO0AeVxelZhrcKqAeQeBEWmNQ96U 9hGZIOcuEZDzJB/LvHCN/TKadd/DGFmprY+ts31x1WPGVXgzkL1XYANu6ceHcGIzVuNN4CO7 e3wNFInDakcWR/VLXBOpFUN9KzweEijfjdEGc7OyI=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Mar 10, 2023 at 12:06:29PM +0100, Jan Beulich wrote:
> On 09.03.2023 17:58, Roger Pau Monne wrote:
> > Introduce an install target, like it's used by other tests. This
> > allows running the test on the installed systems, which is easier than
> > running it during the build phase when dealing with automated testing.
> > Strictly speaking the vpci test doesn't require to be run on a Xen
> > host currently, but that allows easier integration with logic that
> > runs the rest of the tests.
>
> I accept that as a possible way of looking at things, but personally I
> remain unconvinced of this model. To me what is installed should be of
> value to users. If there was a properly separated directory where all
> (and only) tests were put, I might agree with installing. (Nevertheless
> this isn't an objection, merely a remark.)
>
> > While there also adjust the makefile to use $(RM), and rename the
> > resulting binary to use a dash instead of an underscore (again to
> > match the rest of the tests).
> >
> > Since the resulting test binary is now part of the distribution CC
> > must be used instead of HOSTCC.
>
> This breaks the run: goal, doesn't it? If the new mode is wanted, I
> think the two kinds of binaries (and rules) need separating (maybe a
> way can be found to avoid duplicating the rules, which would seem
> desirable).
The run rule is not hooked up in any of the upper level makefile logic,
so I think it's usage (like in other tests that also use CC and have
such rule) is left to callers that know that HOSTCC == CC.
> > --- a/tools/tests/vpci/Makefile
> > +++ b/tools/tests/vpci/Makefile
> > @@ -1,7 +1,7 @@
> > XEN_ROOT=$(CURDIR)/../../..
> > include $(XEN_ROOT)/tools/Rules.mk
> >
> > -TARGET := test_vpci
> > +TARGET := test-vpci
> >
> > .PHONY: all
> > all: $(TARGET)
> > @@ -11,17 +11,23 @@ run: $(TARGET)
> > ./$(TARGET)
> >
> > $(TARGET): vpci.c vpci.h list.h main.c emul.h
> > - $(HOSTCC) -g -o $@ vpci.c main.c
> > + $(CC) -o $@ vpci.c main.c
>
> You're losing -g and you're also not covering for it by adding $(CFLAGS)
> (there should have been use of $(HOSTCFLAGS) already before, I suppose).
Wasn't sure whether I should add CFLAGS and LDFLAGS here, I guess
LDFLAGS is really not needed because the test is not linked against
any library, but could be added just in case.
Thanks, Roger.
|
