[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH
- To: Christian König <christian.koenig@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 13 Mar 2023 09:46:44 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QM65XWZChnp/IbEichNlsNpx2rl4vgW+v/jsTyHVCXU=; b=TyacSM7A0zAgUPW86hqpZkMTJsHNIDsuuhtidLDlrwkIBDcmAhsXYi3NEkhaxYEmbJpGRTxOtSRPBq1Tpay68fhvCXkaLs8LJ4J3eIsFUSnPeOCNeIGHhRwTHsIwWYIynnVG9k8cSzUbRNOgKzElUZHc+clEjdStuxEr97Xi+Q1wvfuR/B+TA8M0H+izIJW74pBYoFHDHKxVprnQ/z/7wpYEA98aJDuTl0K4vz4K+E8FX8QRjzHSUjKxH5SZoL+JH5FnjOafy1GUP8hSqo2A7Yuzgx/HYr9OVw4n6VRZZoTN2P0hPiKbcoI4Le7AJS54NlYaThz+OiHIznQuA7w6rg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JdHjN1LS63LQUMT8R/73jy7M5z6yFZDL9ZSoI+Mx8iFX6EnLdmHRj8YvDL+jTq+NfQCN8yYFi3w7tSDYk6uc1S1FSzyxEI0jsREtKA/9os2B7P6K0++vYRlqRhn4LvzpSqNy5tdvp5b5W6z9hJMMby8i/vgc+0BymCjNGsoce9920E2j45uuBcpyIYBF16UHMX1qMUMxB0HgL6DqfxKCTiV4qWNJSudq1T5JdrJ9GjLyBJtoqpXp20CIhecz61k0GuGYQOI5o/S+tPoSQPq+W4H91jUAA4Qx6r31AcQTcsjekA7/ELk/4k0l9aZMjeolwO+HZLxmZ8gQ6/T7CvODpw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Alex Deucher <alexander.deucher@xxxxxxx>, Stewart Hildebrand <Stewart.Hildebrand@xxxxxxx>, Xenia Ragiadakou <burzalodowa@xxxxxxxxx>, Honglei Huang <honglei1.huang@xxxxxxx>, Julia Zhang <julia.zhang@xxxxxxx>, Chen Jiqian <Jiqian.Chen@xxxxxxx>, Huang Rui <ray.huang@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 13 Mar 2023 08:46:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13.03.2023 08:26, Christian König wrote:
> Am 13.03.23 um 08:23 schrieb Christian König:
>> Am 12.03.23 um 08:54 schrieb Huang Rui:
>>> --- a/xen/drivers/vpci/header.c
>>> +++ b/xen/drivers/vpci/header.c
>>> @@ -392,7 +392,7 @@ static void cf_check bar_write(
>>> * Xen only cares whether the BAR is mapped into the p2m, so
>>> allow BAR
>>> * writes as long as the BAR is not mapped into the p2m.
>>> */
>>> - if ( bar->enabled )
>>> + if ( pci_conf_read16(pdev->sbdf, PCI_COMMAND) &
>>> PCI_COMMAND_MEMORY )
>>
>> Checkpath.pl gives here:
>>
>> ERROR: space prohibited after that open parenthesis '('
>> #115: FILE: xen/drivers/vpci/header.c:395:
>> + if ( pci_conf_read16(pdev->sbdf, PCI_COMMAND) & PCI_COMMAND_MEMORY )
>
> But I should probably mention that I'm not 100% sure if this code base
> uses kernel coding style!
It doesn't - see ./CODING_STYLE.
Jan
|
