Re: [PATCH] xen: fix dm_restrict startup

[David Woodhouse <dwmw2@xxxxxxxxxxxxx>]

On Sun, 2023-03-12 at 19:41 -0400, Jason Andryuk wrote:
> QEMU is failing to signal it start when launched by libxl with
> dm_restrict=1.  When xenstore_record_dm_state() is called, the
> restrictions prevent xs_open() from succeeding.  QEMU can't write
> running to the xenstore, and libxl fails the VM start up.
> 
> Pass in a open xenstore connection.  Let the call back use it and the
> close it.  Use the completed boolean to only allow it to be called once.
> This lets the xenstore connection be closed after the startup
> indication.
> 
> Fixes: ba2a92db1ff6 ("hw/xen: Add xenstore operations to allow redirection to 
> internal emulation")
> Signed-off-by: Jason Andryuk <jandryuk@xxxxxxxxx>

Thanks. Of the possible fixes though, I don't think this is my
favourite. I think I'd prefer to go back to using the existing global
'xenstore' from xen-legacy-backend.c as I just tried in my other email.

Or, as I said there, if the write is destined to fail anyway when
xen_domid_restrict is set, why even bother to try?

Attachment: smime.p7s
Description: S/MIME cryptographic signature