[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/platform: make XENPF_get_dom0_console actually usable


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Mon, 13 Mar 2023 14:45:39 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HcEZVfiRREaBTScrMor7pqjpENjntdcSvNpcolj7YhY=; b=MEgq8VswwyttoWolETC8zxgNuQBBO1b62nRyja3nC1UXEUZuOS2bg9B+uFLW5txDvWKYRP4QPxGI7qyZ0KLBl0+p73SQVCQ2dPj4ZXd/FSRztJjhuVcpTUsan77AjGD8zl22VcNXg119KeWAt80o9jNIJZD/F9FRr9cnWspV7l6iL9qxuov83PrmrX8d3WhGdNre+A11/zlAvCR9WhCzdXlD+FSv8EqjAKF0VEk3ObWOXG5V/Oy2ITiCA9KgKG0bZu7KsUK++NCr30XOvW0B1KKRZCyQcPBC6Wrwu5ZKll/MqxVfoweHH8Wb7oT5lzUz5SnS07f1cg/WMyw2jgMbGg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f13IfpcAXzCCEv6Ae8oMiQZcFyGb1dirub/oAb/JBhV/e39uBjt1rphz/fcaOvUL6u3aYE0wLO+YgWEAknY5QVoHXn9X4ODWoGnc0tVaEa+fJWADln2A+Nen+7ugmqWXFY9Qzw6w5iD3F1khkd98XVBYmhxJN50NMy+FXJzuPJKbTBW/ZaVldwz861nF+mpvBgStsQQfmWKak/j2W9craWV8KIqMwhpIkX28ZmpUIrcwXHaQw1XoZ/pv38YtaCCCI0llIXt9oxpp73T0AnrgaCqRGlvK07LrHkv2Q8I77GiJnr8dFcDqDgTICM3/xTutUgAZwnZz+XNVCbLFm5NcUA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Mon, 13 Mar 2023 13:46:09 +0000
  • Ironport-data: A9a23:p36+Ka88sT7EFnpDnbrHDrUDpn+TJUtcMsCJ2f8bNWPcYEJGY0x3z zNLWGHQP/bZYjCmc9x2OYXk8U1SuJHcmtcxG1Q6qyA8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI/1BjOkGlA5AdmPqkQ5AS2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklx1 LtHFjYsQymBvMKW8vGbTe9KgPYseZyD0IM34hmMzBn/JNN/GdXmfP+P4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWOilUpgNABM/KMEjCObd9SkUuC4 HrP4kzyAw0ANczZwj2Amp6prraXxnuhB9JCSNVU8NZOjF2u6EELUCE7VFyZuKmchkD5WNJmf hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1 FKCg5XuHzMHmKKRYWKQ8PGTtzzaBMQOBWoLZCtBSBRf5dDm+dk3lkiWFoYlF7OphNroHz222 yqNsCU1m7QUi4gMyrm/+lfExTmro/AlUzII2+keZUr9hisRWWJvT9XABYTzhRqYELukcw==
  • Ironport-hdrordr: A9a23:Nd57Eqnx8q+LdFzkQIBuTHGmHzLpDfNLiWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKOzOWw1dATbsSlLcKpgeNJ8SQzI5gPM tbAstD4ZjLfCJHZKXBkXaF+rQbsb66GcmT7I+xrkuFDzsaDZ2Ihz0JdjpzeXcGIDWua6BJdq Z1saF81kedkDksH42G7j5vZZmxm/T70LbdJTIWDR8u7weDyRuu9b7BChCdmjsOTj9Vxr8m0G 7d1yj0/L+qvf2XwgLVkza71eUapPLRjv94QOCcgMkcLTvhzi6ueYRaQrWH+Bwlve21714usd /U5zMtJd565X/9dny85THtxw7j+jAz7GKK8y7TvVLT5ejCAB4qActIgoxUNjPf9kobpdl5lI ZGxXiQuZZ7BQ7J2H2V3amCazha0m6P5VYym+8aiHJSFaMYdb9qtIQauGdYCo0JEi7W4J0uVM NuEMbfzvBLdk7yVQGQgkBfhPiXGlgjFBaPRUYP/uSTzjhthXh8i3AVwcQO901wgK4Vet1h3a DpI65onLZBQos9dqRmHtoMRsOxFyjkXQ/MGHj6GyWnKIg3f1b277Ln6rQ84++nPLYSyoEppZ jHWFRE8UYvZkPVD9GU1pEjyGGCfIyEZ0Wv9ihi3ek6hlWlL4CbdBFrCWpe3PdIms9vQvEyAJ 2ISdZr6/yKFxqaJW8G5Xy4Z3BoEwhvbCQkgKdEZ7uwmLO7FmTLjJ2tTB+BHsuaLR8UHkXCP1 AkYB/fYO1902HDYA6LvPGWYQKgRnDC
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Mon, Feb 13, 2023 at 03:51:50PM +0100, Jan Beulich wrote:
> struct dom0_vga_console_info has been extended in the past, and it may
> be extended again. The use in PV Dom0's start info already covers for
> that by supplying the size of the provided data. For the recently
> introduced platform-op size needs providing similarly. Go the easiest
> available route and simply supply size via the hypercall return value.
> 
> While there also add a build-time check that possibly future growth of
> the struct won't affect xen_platform_op_t's size.
> 
> Fixes: 4dd160583c79 ("x86/platform: introduce hypercall to get initial video 
> console settings")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

With the added comment.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.