[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] flask: label-pci: Allow specifying optional irq label
- To: "dpsmith.dev" <dpsmith.dev@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 14 Mar 2023 07:42:21 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3od9EZp4+IyK5ciI03zGk6lNbxFsEepojwdTrREDVns=; b=VGYH5KL5bkqlRKZEG9I4GxFtFum5sGIP6metTTdj09m27Y0rskRj+QhiIlZAUTOBnfx/jiRpEpepWXalOptr/IGn+KdDUhEcie5fIiOopxskBuYcsH52KAbr2sR1VeOvx0SUoJegT+6OlztHXG7bXSDsRLmeN/N1HJY2TK0YWf0JzdQirLu9Oqi1U7HNJEjpfsZqPG+M+FisM0/s/JQF7QitS9B/txCHxCbiosjvuwm7q6RgRKFoM40Orwx83P3YTxBYQxp2Q55iOdwJ7DPBGYHCX4OEI45BHNZPZq3BhIzNT3TvrgDMgo46LJB44WqlLkaS2cwj3s8PuC4ngVxGjw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cb8C4OzyR74/Y8kbfahXA31iu/U49MmvCLvpbeoqhmTL2IpWJli5Y0qBNMOAAU7PDbZ9pxH6q5vDo4WsV29JbE5fv8sFSMFhHw2sQRTES0uggKgW19RxUc9LYml5X3avh6Mjoy+1mR+eyZSdzmhwMtukFUUoFEDKQB+sXg8rNLcArxVVwLG0vsR85OhsMxTAO55TAVtny7b/uovc61YzYMsIC1d3iRI93bQui93Dis9DSoOt0tJsRE+Sz9fUlXWbL2Mi9gCdAi1WkCv47LBwxh/Cm9G8rBh02OGcHnoyspA5nxWgqmafwRfqNj27BG360MBN/YqFzntXv8UpRSfCwg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jason Andryuk <jandryuk@xxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 14 Mar 2023 06:42:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13.03.2023 22:11, dpsmith.dev wrote:
> On 3/13/23 15:14, Jason Andryuk wrote:
>> On Mon, Mar 13, 2023 at 2:49 PM Daniel P. Smith
>> <dpsmith@xxxxxxxxxxxxxxxxxxxx> wrote:
>>> On 3/13/23 13:50, Jason Andryuk wrote:
>>>> usage(argCnt, argv);
>>>>
>>>> + if (argCnt == 4) {
>>>> + pirq_label = argv[3];
>>>> + } else {
>>>> + pirq_label = argv[2];
>>>> + }
>>>> +
>>>
>>> style nit: space inside parens and curly brackets could be dropped or
>>> should be moved to their own lines.
>>
>> This file doesn't follow Xen style. I think dropping the curly braces
>> is fine, but the lack of spaces 'if (argCnt == 4)' should stay for
>> consistency. Does that sound okay?
>>
>
> Hmm, I thought there was interest in getting everything in tree consistent,
> maybe I am mistaken. I am not hard pressed to enforce the style. Unless
> someone else objects, I am good with your proposal.
The rule of thumb is that if a file is (largely) consistent in itself,
then that style is preferred over introducing a mix. (I haven't checked
this specific file, though.) The same may or may not apply to individual
functions within a file; there it's more likely to be considered one way
or the other on a case by case basis.
Jan
|
