[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 0/7] tools: More Python 3 fixes (part 1 of N)


  • To: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Tue, 14 Mar 2023 14:15:13 +0000
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "Anthony PERARD" <anthony.perard@xxxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Bernhard Kaindl <bernhard.kaindl@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Tue, 14 Mar 2023 14:15:49 +0000
  • Ironport-data: A9a23:l5iQD6m1M3luAA2CFtepqj7o5gxuJkRdPkR7XQ2eYbSJt1+Wr1Gzt xJOWmuCPK7YZDD0etEgYdzko0sPsMWEn9ZnHQA++301ECMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aSaVA8w5ARkPqgQ5QOGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 eUSDBkRSUqBvtKV66/rFa5tnMIbPca+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsWYAx/5JEWxY9EglHWdTFCpU3Tjq0w+2XJlyR60aT3McqTcduPLSlQth/A/ zuXrzmiXnn2MvSN+ACq9iL2u9XFsi7FcrJMBeyG0/t11Qj7Kms7V0RNCArTTeOCol6zXZdTJ lIZ/gIqrLMu7wq7Q9/lRRq6rXWY+BkGVLJ4FuQg7QiXx6n84gCHB3MFRDpMdNwnssAtQTUgk FSOmrvBJxZirbmUQnK17aqPoHW5Pi19BXQZeSYOQA8B4t/iiII+lBTCSpBkCqHdpsLxMSH9x XaNtidWr7cOic8G0Y2r8FaBhCijzrDpQwgv90PoV2SqxgpjYciuYInA1LTAxa8edsDDFADH5 SVa3ZHEt4jiEK1higSUSsEkAJbz5c+1ExbB0QEoHoMnzyWirivLkZ9r3BlyI0JgM8AhcDDvY VPOtQ452KK/LEdGfocsPdvvVp1CIbzIUI28C6uKNoYmjo1ZLlfvwc14WaKHM4kBemAImLp3B 5qUeN3E4Z0yWfU+l2reqwvwPNYWKsECKYH7H82TI/ePi+D2iJuppVAtYTOzghgRtv/sneks2 4832zG24xteSvbiRSLc7JQeK1sHRVBiW8+m9JcNKbTZf1M/cI3ENxM26eJJRmCYt/4NyregE o+VAye0N2YTdVWYcF7XOxiPmZvkXIplrGJTABHAyW2AgiB5Ca72tfd3SnfCVeV/nACV5aIuH qZtlgTpKqgndwkrDBxGPcGs9dw/Kkn77e9MVgL8CAUCk1dbb1Sh0rfZksHHq0Hi0gLfWRMCn oCd
  • Ironport-hdrordr: A9a23:xv9uP6k1d6l+f0wFKrRA2TA+aM7pDfIg3DAbv31ZSRFFG/Fxl6 iV8sjzsiWE7wr5OUtQ/exoV5PhfZqxz/JICOoqTNKftWvdyQiVxehZhOOIqVDd8kXFh4hgPM xbEpSWZueeMbEDt7eZ3DWF
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Despite previous statements to the contrary, Xen still does not support Python 
3.

Various notes are on https://gitlab.com/xen-project/xen/-/issues/114

The following scripts are installed, and given a python3 shebang, but are not
Py3 compatible:

  xencov_split
  xentrace_format
  xencons
  xenpvnetboot
  verify-stream-v2
  convert-legacy-stream

Most of these want converting, and should be reasonably easy, but I don't have
time right now.

This series deals with xencons (which is a not-invented-here telnet), various
bits of cleanup, and various fixes for shebangs.

The problematic remaining script is xenpvnetboot which, while looking
reasonably useful and also not PV specific, depends on a 3rd party module but
provides no dependency information at all.

Relatedly, and a critical/blocker for Xen 4.18.  Python 3.12, which will be
released ahead of the Xen 4.18 release, is deleteing distutils (recommending
setuputils as the replacement), so someone is going to have to rework all our
setup.py's to be compatible.

Andrew Cooper (7):
  tools/python: Drop pylintrc
  tools/misc: Drop xencons
  tools: Delete trailing whitespace in python scripts
  tools/pygrub: Factor out common setup.py parts
  tools: Use -s for python shebangs
  tools/python: Improve unit test handling
  tools/python: Drop shebangs from library files

 tools/Rules.mk                       |   2 +-
 tools/misc/Makefile                  |   2 -
 tools/misc/xencons                   |  92 --------
 tools/misc/xencov_split              |   1 -
 tools/pygrub/Makefile                |  11 +-
 tools/pygrub/src/ExtLinuxConf.py     |   2 +-
 tools/pygrub/src/GrubConf.py         |  30 +--
 tools/pygrub/src/fsimage/fsimage.c   |   8 +-
 tools/pygrub/src/pygrub              |  44 ++--
 tools/python/Makefile                |   4 +-
 tools/python/pylintrc                | 307 ---------------------------
 tools/python/xen/lowlevel/xc/xc.c    | 200 ++++++++---------
 tools/python/xen/lowlevel/xs/xs.c    |   4 +-
 tools/python/xen/migration/legacy.py |   1 -
 tools/python/xen/migration/libxc.py  |   1 -
 tools/python/xen/migration/libxl.py  |   1 -
 tools/python/xen/migration/public.py |   1 -
 tools/python/xen/migration/tests.py  |  15 +-
 tools/python/xen/migration/verify.py |   1 -
 tools/python/xen/migration/xl.py     |   1 -
 tools/python/xen/util.py             |   1 -
 tools/xenmon/xenmon.py               |  44 ++--
 22 files changed, 177 insertions(+), 596 deletions(-)
 delete mode 100755 tools/misc/xencons
 delete mode 100644 tools/python/pylintrc

-- 
2.30.2




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.