[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC XEN PATCH 6/6] tools/libs/light: pci: translate irq to gsi


  • To: Huang Rui <ray.huang@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 14 Mar 2023 17:39:07 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rHDsEukHx1udBc03lZTNtRUsmtrmbaZA4f4XqzD8mWU=; b=JE6E2C7wUvC7iPR3t5fjAcvBI4Q1VIDRaLvHSpc8pTROVzVzoFtHjdOgw2kRNplawmwdfxCbgLa/Odx/ZcL3YnbcthIL4hfO5sgm4qQlQiIWOstpQQjrJcaKuoSQXkp1vE7JPfYDI/Nf0v3I5Kn5Xd7qNp4ZUeArkJb08hDEnCMhKT3TE8Ld67YBVOrOFPrprQh8dktI8Ewk42UUU1pxckGv9nQtRSefigbolm4Jc7tvK+0srGXtduYhQ9/zHJFY0rpSBdPse8BtZ3zQ8bgOfMKoqBoNGfEVJZ7C9bhtG8ZhWddLyYqgKMI+5xC0vQHL1HfV+pBhLW/gWIfb8AHsug==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mzrth0xW+i0/voaI4EeEPKJlqdEUtNWC/2sye0KD+Mxp2il30q6dfEK6Vez3IJX1TuNLhwFqiYE9eyde0Lr9+jRbQfKDNtM/WztQFiD2d1E6nmRgjwLvE73USz4iMosEOL8Bvahbpg3ElI3TjN9muWNrI6mmkqcvBbNa5sVXp7nDgGSi6xNN6kBn0syq1zMhCwOn+1X6eLUfdpqUFWGgd+h2dIseKoTWNNbQyN6Mmka/FwKxpcy/y9Y6s2+97Ggxd5Iyo53lyRaHow+YGGrxK5O23Av8UGzV/rdPsti1SU/tdL2vOnsHbUVf1v41TJ3v/leSSsP3puh9vUvvplPN4A==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Alex Deucher <alexander.deucher@xxxxxxx>, Christian König <christian.koenig@xxxxxxx>, Stewart Hildebrand <Stewart.Hildebrand@xxxxxxx>, Xenia Ragiadakou <burzalodowa@xxxxxxxxx>, Honglei Huang <honglei1.huang@xxxxxxx>, Julia Zhang <julia.zhang@xxxxxxx>, Chen Jiqian <Jiqian.Chen@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 14 Mar 2023 16:39:17 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 12.03.2023 08:54, Huang Rui wrote:
> From: Chen Jiqian <Jiqian.Chen@xxxxxxx>
> 
> Use new xc_physdev_gsi_from_irq to get the GSI number

Apart from again the "Why?", ...

> --- a/tools/libs/light/libxl_pci.c
> +++ b/tools/libs/light/libxl_pci.c
> @@ -1486,6 +1486,7 @@ static void pci_add_dm_done(libxl__egc *egc,
>          goto out_no_irq;
>      }
>      if ((fscanf(f, "%u", &irq) == 1) && irq) {
> +        irq = xc_physdev_gsi_from_irq(ctx->xch, irq);
>          r = xc_physdev_map_pirq(ctx->xch, domid, irq, &irq);
>          if (r < 0) {
>              LOGED(ERROR, domainid, "xc_physdev_map_pirq irq=%d (error=%d)",

... aren't you breaking existing use cases this way?

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.