[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 02/10] xen/arm: add sve_vl_bits field to domain
- To: Luca Fancellu <luca.fancellu@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 15 Mar 2023 10:27:58 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u2Ucg/+mQcDQ4ZiVLFmbIT0n/29YpY/asPhDnanPAmc=; b=Ng2LhteRfp3JUERZVyZ75q0h28ElFbjg3oUXvtCyCtYmOOdAc62LLFSXIyYnoKQMlFTrpk1kwOlV4v5lHpgVf43x4lDZEfa0zNV0weKMfwRg73CT+3dItDabXEwgKvkio8OWdTF67vA1t2e+AILuZK+kzK3sLWznGlAq4kRbY7SvpcF02brE5SAv9FNqd0oiQvdZQv+Mou/d67DL8WLm/W6gZJoEqN47i7Aae6LWPW2TlzXqFx3H2XQjHGQEXc0qui3m6fBbP9mvmbF7lGfQYHokZntsAt2EcLMTjQRfE9GMkXBjPjIefr1Oxt89N+WQn4gpi4fGeE8o+3hft5WhIg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lirrlNmoCsQ2blAeGu8ioUg8dXe/c5qcok1VsTcAlpZYrmTq/hZg9/FMpHpFFu8bige6e5tsLt3xqFq6ILIdGUDxUt0LQxVn6euGsMCoG0ZVw4J6u6Dl3nkiglXkbxszEy6VzA9CRe4jooyCruao3fI8j4ix91bJyuRw1zSLvqtin0kb6e4daNQSNhBcB83r7wOdJrpvDE7sin2uOy+LWIWJVEdKdcZgaeUdTeVJYj0iJbQoSRVT6OsxFrbs4HFsRwBl0eoSbgHdMIBjQr4qybqJ3lcj8qhe06SYEyvyANgXTGY+CXYqXiB7+BJBLtdr31gH2qywQhRQOy8BbnSCoQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: bertrand.marquis@xxxxxxx, wei.chen@xxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 15 Mar 2023 09:28:21 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 15.03.2023 10:05, Luca Fancellu wrote:
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -304,6 +304,9 @@ struct xen_arch_domainconfig {
> uint16_t tee_type;
> /* IN */
> uint32_t nr_spis;
> + /* IN */
> + uint16_t sve_vl_bits;
> + uint16_t _pad1;
Can register sizes be a non-power-of-2 in size? If not, by representing
the value here as log2(bits) the existing 8-bit padding field could be
used instead. Sadly, because of it not having been checked to be zero,
that wouldn't avoid ...
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -21,7 +21,7 @@
> #include "hvm/save.h"
> #include "memory.h"
>
> -#define XEN_DOMCTL_INTERFACE_VERSION 0x00000015
> +#define XEN_DOMCTL_INTERFACE_VERSION 0x00000016
... the need for the bump here. Yet you want to avoid repeating that
mistake and hence check that the new padding field you introduce (if
the value needs to remain 16 bits wide) is zero on input.
Jan
|
