[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] console: use more appropriate domain RCU-locking function


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Wed, 15 Mar 2023 09:45:02 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SBxIoWzt8NIVTLrvW4KLHqb/vkRmEjiCqV7Czk28Eqo=; b=nCrCNqYpfkxMRV38kExFXRdQWQu4L0xS3qCZ2hHmuiM8MxJY7f92utbVaSHctN1qbL9Hp6X9WC0MBLNMZ3Q9yVjWcsHTqgQZtfIYNjm4U1lO871cLYOykjWz9zYYfbwsETEmxwiBoemN1DNOJa8xjL1gc/t+wzFDJjtz8Vm6yp+9AFeNFngQAHJzP03g/HrLwAVWr8vUiEfRotrCcrY/BFBgyA4TUOu438kLS5TKAgrvdPToktYBig9aCFo5vz66Pg/KOfEORXKlgwBNHI7GdcARWaPVTaneOYggQYITo3a2gttJOJzTxQNZI0QWytsDtZZbS+LdSqgSNd669Kp1Ag==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ix8RW+jBelINGae1odD5mUp7K5Y9Hq5dhTnMt66YiEwkzsfmrRKqn5UhDuj2N/qLNfiIGq+id3Fp5vUASm+i93JDSibpYOZoxf8fTOTjozQfPzoYOgVueGCth5AOur0B85JxFcqCiFMVJg3pAE2fyy524piKQrQkUPxlVdwEWQkpmEKcs3S3aWpAGs7EWYKqKrtXgyGsYnpSE78GIqmU/GOWLe5VDPH/IM2+JqrKdgJ4OFw9d12x724FI4zNMpzacgZsgzmSf8nzfkXsDqUqe1N5nuA7XT6h1gl2Tm71S2f0Z7i1h7spPoJtL+UFCllxNdwK41+WKoWpUEcJP32P7Q==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Wed, 15 Mar 2023 09:45:30 +0000
  • Ironport-data: A9a23:F3IHQaCJd3eSNRVW/+Piw5YqxClBgxIJ4kV8jS/XYbTApDgj0WAFz GRKCD/Qb67Zazf2Ld4lPIvgp0tSuMfWzYAyQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFu8pvlDs15K6p4GhB4wRnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwvaFNOEhq1 +4iMBsBZxOqm+CJzry3Y7w57igjBJGD0II3nFhFlWucIdN9BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI++xrvQA/zyQouFTpGPPTdsaHWoN+mUGAq 3id12/4HgsbJJqUzj/tHneE37eXzHmlAd1MfFG+3sIy2nmvxF4MMjxMaHmQjf+UrnCbevsKf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2 1SV2dTzClRHsqCRSH+b3qeZq3W1Iyd9BXQZeSYOQA8B4t/iiII+lBTCSpBkCqHdpsLxMSH9x XaNtidWulkIpcsC1qH+8VWchTup/sLNVlRtuluRWX+55ARkYoLjf5av9VXQ8fdHKsCeU0WFu 38H3cOZ6YjiEK2wqcBEe81VdJnB2hpPGGS0bYJHd3X5ywmQxg==
  • Ironport-hdrordr: A9a23:Kf+ita/GAxx4inV8ePFuk+DWI+orL9Y04lQ7vn2ZKCY4TiX8ra uTdZsguiMc5Ax+ZJhDo7C90di7IE80nKQdieN9AV7IZniEhILHFvAG0aLShxHmBi3i5qp8+M 5bAsxD4QTLfDpHsfo=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 15/03/2023 7:24 am, Jan Beulich wrote:
> While both 19afff14b4cb ("xen: support console_switching between Dom0
> and DomUs on ARM") and 1ee1e4b0d1ff ("xen/arm: Allow vpl011 to be used
> by DomU") were part of the same series (iirc), the latter correctly used
> rcu_lock_domain_by_id() in console_input_domain(), whereas the former
> for some reason used rcu_lock_domain_by_any_id() instead, despite that
> code only kind of open-coding console_input_domain(). There's no point
> here to deal with DOMID_SELF, which is the sole difference between the
> two functions.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.