[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] move {,vcpu_}show_execution_state() declarations to common header
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 16 Mar 2023 12:01:32 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+bDehOTfNAkQLfz1LgU3bXcJBHOB2suIW+GNIqQw1bM=; b=TYjnzyE9L7edo1xg5i4mcM7z8ak79ysD5WMlEucMvxzbTzR0gRtPMMRdVNjr+NhnSTrlMlTB8m6JTQvIkvL+4Ad4rtNZ1sZ/Z3daTQx+hSrshcGJ5+zk9cvGDzdnxxHYsCsXtFqfjzhnbR35zcZWV313L0Qm6SxLSPCP0xt9Ip93N0Ws3IIZznJrqfnwyppS8WmCKqyRl5eP225bfYqUNMWxIGmBu4lR+7DnFSbPn0mCfl5lwyZlZEF7ld2S/vGTsqc4zbNpcmaexaB9wOMhG+7kPGDRPRJ6/iqNjQhfVJ7kzhmiV0BpSTlqa7mauL5/rJcol5KeITh1JmdwkMgm1Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QRfU6HTIvNAW4ErJ6zajewQEtTJa1GsQhFcIIWOAvNv5+lw072dFIBqhUOV2dKxk/Eav5/EpOugZppmEAm3aHs9HGqVHoyBx5+LAM5YsMHcWB30qb2i+QxwNCv5IMqRlLmUXcKMROjSmRyb7ZQ6V2WnGNcrMBQsE8rxW6aVVqKMQqkHEdbCbY3Uk2bK4fc3H4EbK8aei+/FacUVI3c2rRi6bT4marWxqT46Wm58vDGFqE/JiE3S0lrkQAdaj7rjuH+fANty6pH6h79Tf9HRDD7p1Mj/19X0M7g92HDHfQynvWaRNnTQ8vKPwhBBtbhASTAUT+TFg3jnVuJYVazrCcg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Delivery-date: Thu, 16 Mar 2023 12:02:18 +0000
- Ironport-data: A9a23:V2Lyqa+69jZTH2snRLTHDrUDJH+TJUtcMsCJ2f8bNWPcYEJGY0x3n GEXXD2FMqmOZWbwKo9yb4y2pkJUvJDXytRqTQE5qCg8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI/1BjOkGlA5AdmPqkV5AG2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklK9 KMqcxUyZCyZrPio5PGUTulNt508eZyD0IM34hmMzBn/JNN/GNXvZvuP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWMilUuj9ABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTCdNDTOLkr68CbFu7x2w6IUESV3SB+fialnzuR8tUN 04J0397xUQ13AnxJjXnZDW6qnOZuh8XW/JLDvY3rgqKz8L88wufQ2QJUDNFQNgnr9MtAywn0 EeTmNHkDiApt6eaIVqf67OVoDWaKSUTa2gYakcsVhAZ6tPupIUyiBPnTdt5FqOxyNrvFlnY3 DSivCU4wbIJgqYj3aih4UrOhT7qo5HTVxM0/S3eRGfj5QR8DKa7YIiv5Une/Ox3Jo+TRVmcv 1AJg8GbqusJCPmlkyiAQ/4MHfeq+uyCOz3fhnZgGpAg83Km/HvLQGxLyDR3JUMsPsNafzbsO RbXoVkIu8AVO2a2Z6hqZY73E94t0aXrCdXiULbTc8ZKZZ9yMgSA+UmCeHKt4owkq2B0+YlXB HtRWZzE4aoyYUi/8AeLeg==
- Ironport-hdrordr: A9a23:zFHdQaFy6+wrjDCjpLqFlZLXdLJyesId70hD6qkvc3Nom52j+/ xGws536fatskdoZJkh8erhBEDyewKmyXcV2/hZAV7GZmPbUQSTXeVfBOfZrQEIXheOj9K1tp 0QO5SWaueAamRStP3dxiaTMvoL4rC8geeVbI7lph8HcegpUdAH0+4TMHf5LqQCfngiOXNPLu v/2iMonVudUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLolCs2Yndq+/MP4G LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlZwkEyzzYKLiJaYfy8gzdk9vfqWrCV+ O84yvICv4DpE85uFvF4icFlTOQkgrGoEWSs2NwyUGT3PARAghKQPZptMZhaR3e5FMnvNZglI x2/0/xjesSMTrw2B3n4d7GThdrkVfxh0EDv6o8s1xzOLFuLYO4l+YkjQVoOYZFFi/lrJsqFe F/Zfuslcp+YBeUaWvUsXJox8HpVnMvHg2eSkxHocCN1SNK9UoJu3fw6fZv7EvozqhNPqVs9q DBKOBlhbtORsgZYeZ0A/oAW9K+DijITQjXOGyfLFz7HOVfUki93aLf8fEw/qWnaZYIxJw9lN DIV05Zr3c7fwbrBdeV1JNG/xjRSCG2XCjryMtZ+59l04eMM4bDIGmGUhQjgsGgq/IQDonSXO uyIotfB7v5IW7nCe9yrn7DsllpWAkjueEuy6gGsgi10772w6XRx5PmTMo=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16/03/2023 11:55 am, Jan Beulich wrote:
> These are used from common code, so their signatures should be
> consistent across architectures. This is achieved / guaranteed easiest
> when their declarations are in a common header.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> There's no really good header to put the decls, imo; I wanted to avoid
> the already overcrowded sched.h.
Yeah - lets please not make sched any worse than it already is.
I can't suggest a better location than kernel.h, but I certainly would
like something else if one were to be found.
> show_execution_state_nonconst(), being
> there solely for dump_execution_state(), could of course live in the
> upcoming xen/bug.h ...
>
> Is there a reason that Arm (still) expands dump_execution_state() to
> WARN()? Without that moving x86's show_execution_state_nonconst()
> definition to common code would also make sense (it could be done
> anyway, but then at the expense of introducing dead code to Arm),
> perhaps (see also above) into the upcoming common/bug.c.
That sounds like something that should be fixed up...
|
