[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 6/6] xen: pci: print reference counter when dumping pci_devs
- To: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Fri, 17 Mar 2023 09:46:33 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=93WeSr5BtWLHQEeJWLoSd9iHffiSN8bU3At50x55zA0=; b=A3L7x2uV8MZXqVmLEz/hkI3lfpn3boYj4ldKq+zeNHlt6qmzwd6WqFIDp8t14jgKzxxh2WVU33no+3pvJQRL0OnFI9UeEU2TI/qtdvxTt61t9NBrOm7ov+iq5sX8zTWfBLCYMbofAP8Fm/dH5GgO9pZhCbCFI1YSl3uqA4og+9HWQzYC0V4EWIUuo1T6hWQNJxUhraC/Jpc7CgyF63P4W1pJFK/vQlYQ3MgcO9nDVUu/ax9Kvy6BW+/+0NhYL+/+xZco3su8QO5xxS+a3HozqcbktzAGCPrP4GFUUcn6Wg6QroR3I7I20/Zr5SDBpv1kf/3BdZCYwaB5qqFjeRYOog==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M9r1j5hOZs2vdUUcqg1ahBD52yA2dkTdKlz36ZmnETV39m7rDHTOWK35sdOEwhjFbgxfjaCKHW377Wh0Z4DM0n1uj+r1+tXlRG81EQpDJpAxaZ8VEMfvBeervD+ULLY36LFVHzFMmU/YhDkd9rDlk31JiJqMUJKBoqj287DHIOyT881+yKFNXbTq4enhw8CHY6mIbXXgn4rj0KGnx60gWRRRgl9DIsK517RG2D3tG62htdSfjrRwkKog/6i+097qOSDmABupYWLMhvSL+zhYNsbBubc3Asl3NQYO912xTACRSw8HVCZd/MONjgmdNzjLZyxaxAk9t9FpQiwrFBYChQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Paul Durrant <paul@xxxxxxx>
- Delivery-date: Fri, 17 Mar 2023 08:47:00 +0000
- Ironport-data: A9a23:hqEJq6/xP9VypjOqrwTJDrUDR3+TJUtcMsCJ2f8bNWPcYEJGY0x3z WYWXG/VPPqIYGryfd90Ptu+oBgDuMLdn9M3SAdprCo8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI/1BjOkGlA5AdmPqkU5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklK1 9dfMwAzTCmyisnp2bjhSLhxl8IseZyD0IM34hmMzBn/JNN/GdXmfP+P4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWOilUpgNABM/KMEjCObd9SkUuC4 HrP4kzyAw0ANczZwj2Amp6prraXxXugCdxDTNVU8NZ4kkG29kwrJiZNFkq2m6SZjUmaBONQf hl8Fi0G6PJaGFaQZuf6Wxq0sXuVpCk2UtBbE/A5wAyVw6+S6AGcbkAUQzgEZNE4ucseQT0xy kTPj97vHSZosrCeVTSa7Lj8hTG4NDURLGQCTTQZVgZD6N7myKkrhw/LZsZuFuiylNKdJN3r6 zWDrSx7gqpJi8cOjv2/5Qqe22LqoYXVRAko4AmRRnii8g5yeI+iYcqv9ETf6vFDao2eSzFto UQ5piRX18hWZbnlqcBHaL5VdF11z55p6AHhvGM=
- Ironport-hdrordr: A9a23:/cG5hKupvfBdh4dMLgQJiHAd7skCHIAji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhBo7+90We7MBbhHLpOkPEs1NaZLXDbUQ6TQL2KgrGD/9SNIVycygcZ79 YaT0EcMqyNMbEZt7ec3ODQKb9Jrri6GeKT9IHjJh9WPHxXgspbnmNE42igYy9LrF4sP+tCKH PQ3LsxmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzI39QWUijusybjiVzyVxA0XXT9jyaortT GtqX2z2oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuQFNzn2jQ6sRYJ5H5mPpio8ru2D4Esj1P PMvxAjFcJu7G65RBD8nTLdny3blBo+4X7rzlGVxVPlvMzCXTo/T+5Mn5hQfBf141cp+IgU6t MD40up875sST/QliX04NbFEzlsi0qPuHIn1coelWZWX4cyYKJY6aYf4ERWOpEdGz+S0vFQLM BeSOXnoNpGe1KTaH7U+kFp3dyXR3w2WiyLR0AT0/bloQR+rTRc9Q811cYflnAP+NYWUJ9f/d nJNaxuifVnUtIWRbgVPpZPfeKHTkj2BT7cOmObJlrqUIsdPWjWlpLx6LIpoMm3ZZ0zyocokp ipaiIViYcLQTOuNSSy5uwKzviUK1/NHggFi/suqqSRg4eMCoYCaka4ORITe8jJmYRtPiSUYY f3BHtsOY6TEYLfI/c34+TAYegtFZA/arxhhj9pYSP7nuv7bqvXi8f8TNH/YJLQLBdMYBKOPp JEZkm4GPl9
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Mar 14, 2023 at 08:56:30PM +0000, Volodymyr Babchuk wrote:
> This can be handy during new reference counter approach evaluation.
>
> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
>
> ---
>
> v3:
> - Moved from another patch series
> ---
> xen/drivers/passthrough/pci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
> index b32382aca0..1eb79e7d01 100644
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -1275,7 +1275,8 @@ static int cf_check _dump_pci_devices(struct pci_seg
> *pseg, void *arg)
> else
> #endif
> printk("%pd", pdev->domain);
> - printk(" - node %-3d", (pdev->node != NUMA_NO_NODE) ? pdev->node :
> -1);
> + printk(" - node %-3d refcnt %d", (pdev->node != NUMA_NO_NODE) ?
> pdev->node : -1,
This line is now too long (> 80 chars), you need to add a newline
between the format and the argument list.
The rest LGTM.
Thanks, Roger.
|
