[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/2] x86/APIC: include full string with error_interrupt() error messages
- To: Elliott Mitchell <ehem+xen@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 20 Mar 2023 09:49:14 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0qnECW3otFciX8FziyxkerSqu9QxmtNbM1VXdB8croM=; b=moUZSDEU+IAmt73Z03SvERabQq22JBYMaT1g8OFcFF4inmdmakxydb/1JJzJOS1I6bM9Ir5040FPd63F3Low1ew40MtMBa/tPevshbgv6GSKUIw3AXcoFEuXXXWhRmCp9nUqtRrKaYdlZbFcweuDv6wKVhhM7vM/JX2+8tHQe9SjbiWA6ltyv2tCfmO3c/Qmu2uRJMX+qIM0td4aMfj8pumEn6crbZZ+i4bDGnJsPGgUHBID/4rzOZWaPita8PNWhnyqbBoz9ZMSooXBoplmFt23CLlUhebwdMfFtj8zvAcoD1kkvRNLzz7oAqGu7HjCS+apeVTgoSFxOHd5lCKNWg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ek2ZqjFB2bVEYgPKrMmerTMld0DC5eENy2nuF2d662U9NmXZdHlY0xF59NEJ+pB8DEI+eNkb+NR4OWmariC7G2YrzyVx0Nll0UAAMMDJxpE8xkD9Cr15026g9BSUtX3gMZz8A+l4lZx/DD1gywFFvw7gHW/JoZaf/ttMam4m5EM5v+XlrAJeVlLfrzxbrADBxSf3a7OpEe9J5bRghb6QeOsYH1f28bOh9K0GQbSti1FWGDCsIPDZ4LsTV2FduKSWZlO6MzXAfhw+7t9Rw7fnTT4rjYKccyZYlRwWGucd0LgDPk90PDX1U8v2SLBNyuAw9Z1K3GZB0zjhopDxdOPjow==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 20 Mar 2023 08:49:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17.03.2023 20:45, Elliott Mitchell wrote:
> Rather than adding ", " with each printf(), simply include them in the
> string initially.
Why is this better? You're now using more space in .rodata. (I haven't
looked at patch 2 yet to see whether there's a possible reason there
for the change here, but if there was it would need saying here.)
Jan
|
