[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] xen/console: Skip switching serial input to non existing domains
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 20 Mar 2023 13:13:50 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CzKOI6iVSjEoLgjJ/8u8+fttePmh6/XEFxae61/6/Mg=; b=Qbaaut1RbZ1gWEE0MT4F3vMjQnmqTdC9jItp7t9KRdkGyLCNcm8vFwQximn7iBgRcjnENwsztCpfaKuB3RvmQUToAEdUZRBPD1tm59zX8hYA+Ou69Rkdiv08qoux4p5gPk7TCi2xioKx83ZWTwknzKtMx7sL7kq+Z2IRm/UgJuNnatmCLVY+6xnw7lD92gG3XB8aF7F5k/Dj3r1fC8BrSyyM23cDlGDIuQKo3ae+t3FGjystvMRutuuNeDeZCyL6rpSeToiUm+o9yW/Ci/kw3ZXcuT6VwME7ffCi6cfLMiGX0am92xbOg1o27VDowBStz9gwPEhhTDtFmVZGdRG/YQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QxmPTqKxXuWb+ndm6lsEAJDDwbU9gdO7C6TGJiJDX2ceU97Qr6FnY8FbCX9bZYo+ff09K9nFX4tWiRg97F2Oqa1GRehaSqSqkmZqTL/cmUSTZ33bbE8zsoSiKxd+HOBLxmqVgdghbiquVw11hAtKiay9b4eKMDjztffkpHwivB9wgXNgMyVzgSYSFV+y0eEhGwppooPJjfxYEYDDiiNXpUfJVnVYtSRJrthNzXsHc9jkchUB3Pj07CMI8rvAmrCejMYd+EUNPxOaRNOcuC8TLOA77YXzHQLz1eo8G9pMCzdw88rDJUw6xc7MV+g8uhaczmhreIGSiNXxrSGHUuOkcw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 20 Mar 2023 12:14:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 20.03.2023 13:07, Michal Orzel wrote:
> On 20/03/2023 12:17, Jan Beulich wrote:
>> One other transformation for you to consider is to switch to a base
>> layout like
>>
>> unsigned int next_rx = console_rx;
>> while ( next_rx++ <= max_console_rx )
>> {
>> ...
>> }
>>
>> i.e. without a separate increment at the bottom of the loop. Which,
>> now that I've spelled it out, raises the question of why the outer
>> loop needs a condition in the first place (because as written above
>> it clearly is always true). So perhaps better (and more directly
>> showing what's going on)
>>
>> unsigned int next_rx = console_rx;
>> for ( ; ; )
>> {
>> if ( next_rx++ >= max_console_rx )
>> ...
>> }
> Makes sense to me so I will do this assuming that you agree on adding your Rb
> tag also
> for this approach.
I do, yes.
Jan
|
