[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] move {,vcpu_}show_execution_state() declarations to common header
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 21 Mar 2023 17:57:56 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+JWnvlmSS/rEgkcKvReQNnqmSqyhEp8rVlYj9l55BmM=; b=fFREadssMqBJ+jJBUcXW8qrD0s8f3VcMIFGOoiLN/FClPSo/R+oYhkQXFiV8yCJii4OYylg8AZ3kQwt9XGa+DdF0ZL9FPqPToLIPF6HTYNCD62gZlgs32CHG9vhXb7u4mtFX2MgJb6eQCsqNwZWDwFrjv/2xvUB0RxUs9WUZfqIBHrlb6hFrL2n4h2sYcBW0GuRsQBH+NOcjKajKzgBWWtppAtRd9hAWjVb3ZQ3ngaGTpNu0YbuEMcO+hVLbqbVB3STNXgTUF3MMoX6wyxfugm0LRf+dfqG7ys3dEDAc5F7GbUnNP6Ns6MpHX3wcn6RYumsPVx4pKpgp+9tzOlg96w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EpGVprCSIueOR58k+eOsxA1P4eY3IxUE/R7jbxaNgm50fohF0VSgj1flUfitMDq96ovCxOE3S+/QJ0MgMy0FgPWOOYCw0xQWAUuRVbRfq1H4geThaoTGp0Pt4bdMIC/8VZjewwdYtleq9nKSCN0vKqc6jbg8GZi8ZuUPygGnsSTrSd4RMSgX8syMnssYtlFH/bFJ9UxYS+Qh6ijfvSikD48UYYn6UMzs15NTAOsNI4DLC1MFK3TCdLhsS4IWpjsSSUsf+Ln3UYqGVyjcgDEGTf0bsRTxxlJ+Y/uxYm1ZU0gTTqCnV5CXrfWVrbldBQu3Hu1UioKGVzzuYFJCnQS31g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 21 Mar 2023 16:58:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 21.03.2023 17:44, Julien Grall wrote:
> On 16/03/2023 11:55, Jan Beulich wrote:
>> These are used from common code, so their signatures should be
>> consistent across architectures. This is achieved / guaranteed easiest
>> when their declarations are in a common header.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> ---
>> There's no really good header to put the decls, imo; I wanted to avoid
>> the already overcrowded sched.h. show_execution_state_nonconst(), being
>> there solely for dump_execution_state(), could of course live in the
>> upcoming xen/bug.h ...
>>
>> Is there a reason that Arm (still) expands dump_execution_state() to
>> WARN()? Without that moving x86's show_execution_state_nonconst()
>> definition to common code would also make sense (it could be done
>> anyway, but then at the expense of introducing dead code to Arm),
>> perhaps (see also above) into the upcoming common/bug.c.
>
> run_in_exception_handler() was only properly implemented a couple of
> years ago on Arm and we didn't switch dump_execution_state() to use it.
>
> That said, the current implementation of run_in_exception_handler()
> would not be correct for dump_execution_state() because it clobbers
> x0/r0 on Arm.
>
> This should be addressed with Oleksandr work to consolidate the bug
> infrastructure. So it would be fine to move the helper to common code now.
Well, Oleksii's work hasn't landed yet. I'll try to remember to follow
up once it has.
> Alternatively this can be left as a clean-up because
> dump_executation_state() could now be common.
>
> Anyway:
>
> Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
Thanks.
Jan
|
