[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 06/10] xen/arm: enable Dom0 to use SVE feature
- To: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 22 Mar 2023 08:51:21 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0A/j0taGy1Zf1ABWstIOrlCKjhX9BwMhwrK6NnO/ToY=; b=Rlq9XvHOVjZvgCDl4rJCi+DQElWQKWcCL3Gejgzgg7RyMD/oUH0fgOFrYDRSRBJ2mZLb6d4GnSm6wRHDeyCc4U2H/px24a4FLSURMPpSrYXKTfxCgaQZPDbreafyiIKMLtlKRWP8n3T/GYrhpLlCGINE5Oq+U4cRyj5EdYrulDkeCc7YbrJIqGTRaAd29kH24P8uwN06+XJKyxeZJG6RpJH+g2mWojzxKECvsQ5GBbuF43Xpf9Rsf262jdLlmkJkBoTKtRm1R9m3S2zBaLEnyKaP03ArNMNpzkVM0Y+R/k5P+9W4A7a5SvoQbPN2FbPAlSjLweXLFm8k/nVL5YCJYw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iUNsSwPnDUXaBBa4+9Kbrf8Cky3ojxSBhnH/Ad7U7110N5I11jvmIT1+qKP0Vnr07zXRSWRURKUGb7IliKOCcuDtJx718IQg7W5jykrRJj6IyFEvsN6IiXU7PLK//LR0dP3Zq8xk7T/wjk0NoS1yyiuCyMjvrnr3e5H79GDECAcHvi8i33ZAewxkge3I1R9vKvLcK8PbmrhtE57J3O8CLL0Uz+mn6DlOEE0CMAPu5r068wbKZAqkMgRA+Iuf54gr84/A5TG/MOudNzs87TmxVEYev7f5ln0fLWWIVrL0RHkKGEs7mNsrZsKmG9bHbEKEGBte7hbQE2hV3zRqR13P7w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 22 Mar 2023 07:51:37 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22.03.2023 08:32, Luca Fancellu wrote:
> While I was browsing the code, I spotted a possible bug in x86/dom0_build.c,
> in
> parse_dom0_param(...) if an option is not recognised we set rc = -EINVAL, but
> we don’t
> stop the loop and we continue to parse.
> Is it the intended behaviour?
My view: Yes. But I can see how one might look at this differently.
Yet iirc the same behavior can be found elsewhere as well, e.g. for
"spec-ctrl=". The goal is to parse everything we recognize, covering
for people using options on older hypervisors which are supported
only by newer ones.
Jan
|
