[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v2 4/4] xen/arm: Clean-up in p2m_init() and p2m_final_teardown()
- To: Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Wed, 22 Mar 2023 08:16:24 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mmjL4GQTBS8g/UNMWGpjhLDq161rA8RrBkoWZWp2SfU=; b=jf5suM2p6y6C62ysJU8mJGPkz5Zcf1idDbJ8Cd6eTNKpiWPrKkXEU5MEDugMed30akI9rGgq62gKdrpzWNXV2+6jOSA5cdosnU8XxdYGS++CFH8zTCyGYX0TzgQ8TQqJGZN5SEDfSqRtEnAYWuv3mYp6sMz+cnAE0kf635UqmQz50AnPp4lVJmSixaSZvwRtwdcTBFl3KI5GW26AVRK1WveZ1Z50kSfKyzKnbbFUrRdX2vhHtMoS7M4L0P9Yz2vtdDg4Z8U2xAxiMWnR1G7U+Rz4RPI4lgpVxoDmINfB/Tn/SF/lVE3f5XpCH3zYNTLfWFj9kqPKB0uWqo/nPSF+9Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RglMv6FPvi2D8wYLz0+hz13Tm0RVhC6WSlH3hjs+GDc1pPETGEeVWizlbZOEMF1mqV7ZoejDn3V9pb3z3+3AAr8PioQQbLiwFJXNlGwqhFQVe9HqzcjPm3LUAO9JDkjzJ04z+ktkETrXVj6j69U/PiO/gHftgFvNbSco1BFCqC41+5TGO3mbYObNdp9ZzgoARxqIBgi/gLzLTS72w88pOQZ/Wse2B39Ny3KX6PxhYNshgK1v/DmGb1yNriWtbsQtib5WIBtskijY/39CdKyOA7CwQNuY/3prf8Yq2pqaY7LXO4qlSwbP7Y67HqoqGWbHJorOhzBQRhqHMWf0oPFADQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 22 Mar 2023 08:16:53 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZNGBFU1FB2zU45UWPsIKl0/PSm68FsPqAgACrD/CAAGR+AIAAAJlw
- Thread-topic: [PATCH v2 4/4] xen/arm: Clean-up in p2m_init() and p2m_final_teardown()
Hi Michal,
> -----Original Message-----
> From: Michal Orzel <michal.orzel@xxxxxxx>
> Subject: Re: [PATCH v2 4/4] xen/arm: Clean-up in p2m_init() and
> p2m_final_teardown()
> > If you are happy, I will take this acked-by. Same question to Michal for his
> > Reviewed-by.
> The diff looks good to me and surely you can keep my tag.
Great, thanks!
> However, we might want to modify the comment on top of p2m_teardown()
> prototype as
> it assumes presence of preemptive/non-preemptive p2m_teardown() call (at
> least this
> is how I understand this).
I understand your point. I will revert it to its original form written by
Julien:
"p2m_teardown() will be called when relinquish the resources. It
will free large resources (e.g. intermediate page-tables) that
requires preemption."
Kind regards,
Henry
>
> ~Michal
|
