[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 3/7] xen/riscv: introduce dummy <asm/bug.h>
- To: Oleksii <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 22 Mar 2023 11:27:11 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mtiQ8vpdfyx3vlDkymM5GOPTXUdgwKUiXshlAOXxcQc=; b=GHf0V28Ps1KSkoBvXlZj44HFKvX/BMGZx2bwBNpvaGGsihtlyvRdqLiLVL9XBKKqzqUQn0Zuujy4qNfGU8T96h33Nhl0Dm5QtZpWtpiTU9Az1ksUu5JODdgB+bnFN4a4qcj9W6NZnTd5/bJ8ksBOQ5vgP3dA6sDlvXoEGO58ykY0B2DoNRKG0m1C9rXJiiGPLKCbYPqBHRdb8K4OLeO2lv3hF/gBxE6o5/014DWOgi5lMPhpCmnmK0mgfqZ3MzT2N0dWhEwgdkIBNsmCvQl+XIY1kn6ZgZ87O9CtBdw0U/M8ZDKHOQhESsy510e9Ty4CMHU0yuPS9uvd5/NwzUHMng==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e+Qj4U1Lo+iiFREuNtEr5MjIQ7QLWSFmooTmm6AXUFPpm3/7S/XM9/ibsPmV5eka15rOeKGq8GpqTZ69jQ6OrLW/ewZbSlyAMp41ts34TyKWOd3CvyApvIvYPH8DG6enpxgoFnx9b4SNT1TeX5P8Ra0hXYjoMBq7vGVbv1d3cBufuTgwljvkZBFP9DseU1vj31uXrPQ0iDde4K+hE58In+k+xwMuCz17wb0BfQiHSN1wcrVPDm8+FDGtk31yG0+FUsGzMEvr8riKuuV7lgvOaxxp02rKItqmjvhK0DFhDvH9QuTCw9rBmPmfpykoMvUlo7PGiRqYSU+6YaBGfaj/hg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Gianluca Guida <gianluca@xxxxxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Julien Grall <julien@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 22 Mar 2023 10:27:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22.03.2023 11:09, Oleksii wrote:
> On Tue, 2023-03-21 at 17:21 +0000, Julien Grall wrote:
>> On 16/03/2023 14:39, Oleksii Kurochko wrote:
>>> <xen/lib.h> will be used in the patch "xen/riscv: introduce
>>> decode_cause() stuff" and requires <asm/bug.h>
>>>
>>> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
>>> ---
>>> Changes in V5:
>>> * the patch was introduced in the current patch series (V5)
>>> ---
>>> xen/arch/riscv/include/asm/bug.h | 10 ++++++++++
>>> 1 file changed, 10 insertions(+)
>>> create mode 100644 xen/arch/riscv/include/asm/bug.h
>>>
>>> diff --git a/xen/arch/riscv/include/asm/bug.h
>>> b/xen/arch/riscv/include/asm/bug.h
>>> new file mode 100644
>>> index 0000000000..e8b1e40823
>>> --- /dev/null
>>> +++ b/xen/arch/riscv/include/asm/bug.h
>>> @@ -0,0 +1,10 @@
>>> +/* SPDX-License-Identifier: GPL-2.0 */
>>> +/*
>>> + * Copyright (C) 2012 Regents of the University of California
>>> + * Copyright (C) 2021-2023 Vates
>>
>> I am a bit puzzled with those copyright given the header is empty.
>>
>> But is there any reason this can't be folded in #6 or part of #6
>> moved
>> forward?
> Initially it was folded in #6 but in this case a build will be failed
> after introduction of #5 as <asm/bug.h> is needed for <xen/lib.h>
But what about the other option Julien mentioned, moving ahead the
later "filling" of asm/bug.h, so it wouldn't be introduced empty and
then (almost immediately) touched again to actually populate it?
Jan
|
