[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v2] build: detect compiler change to rerun kconfig


  • To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 22 Mar 2023 15:13:42 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tk5dJmoYspXo1dpTSv3sSNfP/AX01SlK860/F1mFoNg=; b=UCMIjoma5Bah/OWU7V9h2Ru862Pd7zGNqca6sQoSeOc+AIHlxaOSQAWv0WoRIDq/LDWPM8wdhNgRzBFdFKDy5Y9tp4NthZCq0mh1wT1vfSKfcA8ErErNhyjC52b0bBc7f9I9v3VA64FttIU06LHFfXF+EQ+xnqOBWZkG91WcokJ9pRHdIC/3IMa/P6T7JfuNbSY51ocXTLzCXZIq/tfwAtsnUSBdKjMXshED6alsnkgdh9/4j/uRuVVQ4qBveZAjCJy0c5QWNJEnspV2Yvk/RT1iMWcXwOEiHMq3sCVFqDhPg42m+BQ/weGT7SFbZls+I0yKTEkVuVPgw7CeCt6KfA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mulVxBlkFjxCtByDrfD3jC8MjbJGn+ev1iOurJh8S15yNfycMvEe0YwF5kEEfsQ1ipbuMlo8SUEQ/hmj6P63tfdAHcjdWo+tqdWBhDDCRU1olAuN4c4SlgzCqWbOEg35SuWgLGZgzwztSv2xWw4IKvzr0QkyMrVbwsSPHNy8sARMNcEQrwRk+sLXEwdmmk1jl75mH85wuA2hks94q1g1b5tJe+7vYT4tH87Li0ZKR4MY6JQ3WBWpb8nqv4pP2jKumhv0RahvxJddybdeLrLhEjsFlleQx7ZqjQHjTwugDcEPIi+Fvq24Rs7m2xMQ+KVW2BMn6ok8ZeSHd4VLuQm3ww==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 22 Mar 2023 14:13:59 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 20.03.2023 16:28, Anthony PERARD wrote:
> This simple comment allows to detect when $(CC) changes version.
> Kconfig will be rerun in this case. (Rerun is forced by
> include/config/auto.conf.cmd which detects changes of CC_VERSION_TEXT
> value).
> 
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> ---
> 
> Technically, it was acked by Andrew:
>     
> https://lore.kernel.org/xen-devel/20200326135621.687685-1-anthony.perard@xxxxxxxxxx/t/#ma1171775b9938bcdffc80b2fcb8d2a883cd3e32a

And technically - comment visible under the same link - this still
isn't what we would need to address one of the arguments around not
storing tool chain capabilities in .config: The version string may
not change, but an update may still have brought a new option the
compiler understands (or a downgrade may have taken away one). In
fact this change is working against the proposed direction of not
making .config contents dependent upon tool chain properties. But
of course that proposal wasn't adopted yet, so for the time being
this still looks to be an improvement.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.