[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] tools: use libxenlight for writing xenstore-stubdom console nodes


  • To: Juergen Gross <jgross@xxxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Wed, 22 Mar 2023 17:10:11 +0000
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Wed, 22 Mar 2023 17:10:38 +0000
  • Ironport-data: A9a23:izwCnaqsRwkgagtbhT5KWFucJIheBmIWZRIvgKrLsJaIsI4StFCzt garIBnSOPiMZjCmKdh0bIWz9k4DsJ/RydNhTVdurX88RXsb8puZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WNwUmAWP6gR5weFzSNNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXADktZRynh/Dq+42EEMQzguA6LcfQBapK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVRrk6VoqwmpXDe1gVr3JDmMcbPe8zMTsJQ9qqdj juepj6nXkhCZLRzzxK43yyTn+rtnxreSd1MDpal891IuH2Mkzl75Bo+CgLg/KjRZlSFc9BQM UsP4QI1sLM/skesS7HVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQ5sOcmSDps0 UWG9/vgHTF1uaeZYW6c/LyT6zi1PEAowXQqPHFeC1Ffup+6/d9110iUJjp+LEKrptTVEj3Uw yLWlxcB3ZhMieoS1quAxHmS1lpAuaP1oh4JChT/Bzz6v1gnOd78PORE+nCAs68ecd/xok2p+ SFdxpPAtL1m4YSlznTlfQkbIF2+Cx9p2hX4iEUnIZQu/i/FF5WLLdEJu2EWyKuE3685ld7Vj Kz741k5CGd7ZifCUEOOS9vZ5z4W5abhD8/5cfvfc8BDZJN8HCfeon4/ORTMjj2wyxh1+U3aB ap3jO72VSpKYUiZ5GPeqxghPU8DmXllmDK7qWHTxBW7y7uODEOopUM+GALWNIgRtfrcyC2Mq oY3Cid/40gGOAEISnKMqtB7wJFjBSVTOK0aXOQMLLfdf1c8RTBwYxITqJt4E7FYc21uvr+g1 hmAtoVwkgSXaaHvQelSVk1eVQ==
  • Ironport-hdrordr: A9a23:WBAXs6i9TAtlLWZzDmAdQ/cQDXBQXmEji2hC6mlwRA09TyVXra GTdZMgpHnJYVcqKRYdcLW7UpVoLkmwyXcY2+Us1PKZLWrbUIXBFvAf0WKg+UycJ8XGntQtqp uICpIOduEYb2IbsS+K2njdLz96+qj/zEnAv463pEuFDzsaCZ2IiT0XNu/xKDwSeOApP/QE/b Onl7t6jgvlV3QLT9ixQkIIV/LEoLTw5ejbSC9DKR47yRWEyQil4r7iExSew34lIkhy6IZn32 jZshDzop6uufGjyhPayiv64plMlMH6o+EzdPCku4w6KijMlg3tXohnVrGY1QpF2N2S1A==
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Wed, Mar 22, 2023 at 08:29:39AM +0100, Juergen Gross wrote:
> Instead of duplicating libxl__device_console_add() work in
> init-xenstore-domain.c, just use libxenlight.
> 
> This requires to add a small wrapper function to libxenlight, as
> libxl__device_console_add() is an internal function.
> 
> This at once removes a theoretical race between starting xenconsoled
> and xenstore-stubdom, as the old code wasn't using a single
> transaction for writing all the entries, leading to the possibility
> that xenconsoled would see only some of the entries being written.
> 
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.