[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/ucode: Fix error paths control_thread_fn()
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 27 Mar 2023 17:39:36 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kXE3NMlpQTWxogyqp9LmhYc2ZvZ2B0l7htTM+Xf/OVQ=; b=QAcq3AzT0Fi6ZYC2ZSf2X2xcplW4aFV2iFEGSdp+ocW4vgadbBC2g3egPGuwLwJwFwSmP4aFrgeHTKFi11waZeoR8GFyh8rQc/oen9Xd8zFIX+7AK058RipCbTYM8Nx20clClyQSe5lg2apsFL9Z8dO2XlNqaqaWmIovVMuMrGLEfnfQJS6LflyA8hUJaORKUoBn54EQihqMQnz3+bZ4lt5ARW9w7uaptoDY+CYYBnYmHaITmNsWsFv7weC9Auc69sBTEzL5Blij/gF1y/UEJSev37LkkniHkzdBTA6wXTvzX+ibANHGU0OFVGRD6RgvwUg5PmjYeu1VKXPbn72sRA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T9HPraDPJ9h1zti4lgXI6htWeQV5Bwtf2OABHO6aDm1y1z7E5l9u5uUGUPKO/E2CuJpMz2cl1GqNcsr9hUr/QIRETKiSCVSYoLKPF96aYC3ruLjDYEcj8JC8q/4UM3DMlYKd1PKMDKBigsRgaiDtlZ/IZSmw4qF6Duu8xHIU4Kz1+DcvQ4raR2NvrNiHqOl00J6YvUCcXaZs8DsKk59baXA3zUxy8mdbZXWmO2cQ88OdeW+iSRP6l/s+AK0uLaR4osHz7oO7Z0+U0pzbLU5JCTHNEx5ut9xuZa086JfUGwv0vAIFVKVONtOepk32wzGvq+2NHWOCUO/sL2Tsho9DIA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Sergey Dyasli <sergey.dyasli@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 27 Mar 2023 15:39:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.03.2023 22:44, Andrew Cooper wrote:
> These two early exits skipped re-enabling the watchdog, and restoring the NMI
> callback. Always execute the tail of the function on the way out.
>
> Fixes: 8dd4dfa92d62 ("x86/microcode: Synchronize late microcode loading")
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
As a bonus you also avoid nmi_patch to hold a dangling pointer. May be worth
adding to the description.
Jan
|
