[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/3] xen/netback: fix issue introduced recently
- To: Paolo Abeni <pabeni@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 28 Mar 2023 15:57:05 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+9TUmBIYEGl46AeH09cvKAPol47UwJJ/LDEqA7e1ToQ=; b=Vwb4EHEdSM0hJJ0zPhWZQvMo2c4Wwenl5os9Au3XjwcDaQ3Wkdg9ypnrx8mvXRdiR++7+uCCluDgZ6DNd3Cy8/QCOHqELy/3RqzehaBta2OeufCn4cNNaX4dDmcngQ7oDzVvtiQ+MDreu+7gMR9F/A7Ww8qV3HYeGM57hCDx8wzTGNy5Lzy2e5AGWt6bTTCBGpA9OOa6YTLPDmH2z99+u+isAkV5b01m4yyKEMJBNWMqVZHKAVNIxqaU1uOINvijm3ZQPDJQKd8CEPjI9GOIViXVfO/IcAWMFXCSN/xV3seyxgn+2DcXkaZS0cLfj2dUnJM0/h/zoCuhYs2voEwmNA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qb0D4sYCQsB0e+GERBn8qAvDQG/zsiOhGZWGgwJCeBQv/ucU3c1pMN11r7sZJPtAY4h9Y2dQSAHclD4Yadg7pj5uMEGiW0Aizu31DzhQn9xJXKwTVAvT/Bw9qvHaTQGpPo4u2VXbEMo6PFXXmdWU7bIpyf9jYJz5n7rBIATg3M5QCNlbKwwritz7q9j+Ht64hk26Vm3anwoUNFrcvimiE7V0NBjhrnAX+YkAKzZ/Al4yX8YY418z9yjef+KN/EVPLy8m7mBNDo5xSadexgp/m5NaS3C0Id4hqNbk2rS64hYdI4hvYZT+Z70URLtgdwaSxZRjsqHeU9lxFc6qgNwp0w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Wei Liu <wei.liu@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, stable@xxxxxxxxxxxxxxx, Juergen Gross <jgross@xxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx
- Delivery-date: Tue, 28 Mar 2023 13:57:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28.03.2023 15:52, Paolo Abeni wrote:
> On Tue, 2023-03-28 at 15:10 +0200, Juergen Gross wrote:
>> The fix for XSA-423 introduced a bug which resulted in loss of network
>> connection in some configurations.
>>
>> The first patch is fixing the issue, while the second one is removing
>> a test which isn't needed. The third patch is making error messages
>> more uniform.
>>
>> Changes in V2:
>> - add patch 3
>> - comment addressed (patch 1)
>
> I misread the thread on v2 as the build_bug_on() was not needed and
> applied such revision.
I guess it's not the end of the world if we go forward without that extra
check. It's a safeguard for theoretical future work which, as Jürgen says,
isn't very likely to occur anyway.
Jan
|
