Re: [PATCH v2 1/8] x86emul: split off opcode 0f01 handling

[Jan Beulich <jbeulich@xxxxxxxx>]

On 28.03.2023 16:57, Roger Pau Monné wrote:
> On Wed, Jun 15, 2022 at 11:58:46AM +0200, Jan Beulich wrote:
>> --- /dev/null
>> +++ b/xen/arch/x86/x86_emulate/private.h
>> @@ -0,0 +1,531 @@
>> +/******************************************************************************
>> + * private.h - interface between x86_emulate.c and its helpers
>> + *
>> + * Copyright (c) 2005-2007 Keir Fraser
>> + * Copyright (c) 2005-2007 XenSource Inc.
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> + *
>> + * You should have received a copy of the GNU General Public License
>> + * along with this program; If not, see <http://www.gnu.org/licenses/>.
>> + */
>> +
>> +#ifdef __XEN__
>> +
>> +# include <xen/kernel.h>
>> +# include <asm/msr-index.h>
>> +# include <asm/x86_emulate.h>
>> +
>> +# ifndef CONFIG_HVM
>> +#  define X86EMUL_NO_FPU
>> +#  define X86EMUL_NO_MMX
>> +#  define X86EMUL_NO_SIMD
>> +# endif
>> +
>> +#else /* !__XEN__ */
>> +# include "x86-emulate.h"
>> +#endif
>> +
>> +#ifdef __i386__
> 
> Do we ever build this code in 32bit mode?

Yes, for the emulator test harness, which can be built both 32-bit and
64-bit (like all of the tool stack can be). When the tool stack is
otherwise 64-bit we even have Makefile logic there so the test harness
can be built both ways in parallel (and hence things can be tested both
ways, provided 32-bit runtime packages are installed).

Jan