Re: [PATCH] tools/ocaml/mmap: Drop the len parameter from Xenmmap.write

[Christian Lindig <christian.lindig@xxxxxxxxx>]

> On 24 Mar 2023, at 20:25, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx> wrote:
> 
> Strings in Ocaml carry their own length.  Absolutely nothing good can come
> from having caml_string_length(data) be different to len.
> 
> Use the appropriate accessor, String_val(), but retain the workaround for the
> Ocaml -safe-string constness bug in the same way as we've done elsewhere in
> Xen.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Christian Lindig <christian.lindig@xxxxxxxxxx>
> CC: David Scott <dave@xxxxxxxxxx>
> CC: Edwin Török <edwin.torok@xxxxxxxxx>
> CC: Rob Hoes <Rob.Hoes@xxxxxxxxxx>
> ---
> tools/ocaml/libs/mmap/xenmmap.ml      |  4 ++--
> tools/ocaml/libs/mmap/xenmmap.mli     |  2 +-
> tools/ocaml/libs/mmap/xenmmap_stubs.c | 11 +++++------
> 3 files changed, 8 insertions(+), 9 deletions(-)

Acked-by: Christian Lindig <christian.lindig@xxxxxxxxx>