[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] drivers/char: Use sub-page ro API to make just xhci dbc cap RO


  • To: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 29 Mar 2023 12:28:33 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t6xRqmJhY1xhZvRzBSlkPEWOc2x0ZWxkS7h9y+lJSOg=; b=b0q6Cbca8HuoI2lbnX9IwLxCKGysMSVs5n6FsD/0/yYKYmBvYCFtO54mxp9ML70goZhyDdD0Mewh+lqC6UFDkB6nLYdJYi2rjCnf7pd8oedruPPTI8xm9/CEJlH0MRI9ULz0XRpTJevbLF87eXPIp4ugBJeEEkXd+hdY2p8jTtKmPuv2nx8ypfg4BIMBikehLX1hr0LTWCxrgD3K3YTpR9TvXqCLWCSKeW7WhP9q4pnFQJnMz/jmbr7NH3mMWadlfECHLln05TYLvyHoCwGZ81AP6kdGx65uLYLBQLOdwpsgnhgKMWmV9eMfRQMer4vpTTfwzvajNcZICkUtWBQfAQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N1H6qMJyraKyUvv5yUMguUYiomjcsc+QPF3jyXEQdSouFBMC3Z0YipItSZjc5Wdk0GzZbPKRqA8WCy+H7pwXWDHmSZzKgIcQHYnChDD68WiHIrvI4HC57tHypkLS5oD6QwSwGgRO0CTgW9Orh5x+PDCKeU9P59v6NIOHhFEx3fqy0z7VYnFzL+0Cm4+g4CFIruZeEOu52YTBbb9u9e74uJNh8CLgP5tNp7scpYJc8rcnSvermFmkNyUgo5vgaFxFviH2YkcGBLngGapkhxemZsv8SQAlqJj1bEqB/R+LzdoS85oNGLFaJsDtlYVBH4va1drn1Y6B2UzAKzz7o+EtQQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 29 Mar 2023 10:28:54 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 29.03.2023 12:21, Marek Marczykowski-Górecki wrote:
> Making subpage_mmio_ro_add() to call mmio_ro_ranges() on its own,
> together with Roger's suggestion of using ioremap() internally instead
> of using fixmap would make it a bit nicer (if mapping the same page with
> ioremap() in addition to fixmap isn't a problem).

I don't see any problem there, as long as we don't gain many of these
(at which point wasting address space may become an issue).

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.