[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] vpci/msix: restore PBA access length and alignment restrictions
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 29 Mar 2023 14:51:18 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9T39mK3XpB8Qy8WK3dRWFWUJy9x62EEydfVSESKViGg=; b=llyTdefLIRIDiTlRSebVjC5D4vVYQD0z6+FLxseAcCO0wx2Rd4n+I0IPlNq0SdUzNNGEgqt1GQwMwFzIFv5ULKhEaDqvBq9tl9XWxRs/sj+EKZZn+9ZIAfFOCVUQDKNPKyBadzMDudqALmLf+39aZj5HwtGv5u+CjoD/QKAE5Xp7WpOPDDrKinK9fF8kB97G4ahJexOHRy1APv0SQOoVzXeb9peGBv4OWaH14+GIaR4ARqfYXiXQfOSdrW86Ob2IwGsZmwme/biN0sthiFE+/zYaH5kB2jhGQ9BpRP94rQQBpgUZ2hz2ELoiPB+xTRQzbGX0AagCKSgyUcjag7abFA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I3fgq/nmIfYSDNI9Zb+VIJMzSFZBJXTSL+O/O/5ino2hKqE6+pQgGW25d0o7Jap+j0xkGcOHqzcS8zhsrReCLxNH3WlqoF6ltvXFw26YARF7Sx06aeD4h0l3bWD4xtODKGPr2ILyHLu6CErWulST2rh4koafGAvLJfrAnOZNaKuxzX2MXEC7NfdvonDMIicAqujbfu+6l5jBZ2WhMa1ol0Ac2tPrQeyVyBnAONoR2/puOOpZDTmdoyTOs/6uhYKyYy5joz0qSHmfUxxcC8WnnLLC4WiG2EVVV3wXOSDMoz+4MFPgPaadjauRfSqtG1Db7qcSNUtH39mjHJ4Jg73L6Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 29 Mar 2023 12:51:37 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29.03.2023 12:18, Roger Pau Monne wrote:
> Accesses to the PBA array have the same length and alignment
> limitations as accesses to the MSI-X table:
>
> "For all accesses to MSI-X Table and MSI-X PBA fields, software must
> use aligned full DWORD or aligned full QWORD transactions; otherwise,
> the result is undefined."
>
> Introduce such length and alignment checks into the handling of PBA
> accesses for vPCI. This was a mistake of mine for not reading the
> specification correctly.
>
> Note that accesses must now be aligned, and hence there's no longer a
> need to check that the end of the access falls into the PBA region as
> both the access and the region addresses must be aligned.
>
> Fixes: b177892d2d ('vpci/msix: handle accesses adjacent to the MSI-X table')
> Reported-by: Jan Beulich <jbeulich@xxxxxxxx>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
And thanks for taking care of this so quickly.
Jan
|
