[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/5] multiboot2: parse console= option when setting GOP mode
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 30 Mar 2023 08:24:20 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7mOdC9rQoLl9g0HVThCVCan8x/t97IU3MikBflDksjk=; b=QVZWywIcwLqyC7ft/O/1cr30ru30ocC9VSZ83q/NgAhs/0cNpNRFoSfdXSRmjY73nW1FbrNb+jZOtHUCDmrLJzcQujXcTJGSe2zRZgjhJmJBNggDCQghTxidPO6wa/4Z46qXASN6diig2aGqkFCdeW1xW1Jy15IwlccHMpEmKGAEAzk+2ib3EIbTHozChkAG/bVDmQFytSs1t0dOT81EwB6jRyTFKNqkdN6OFz/LrMaEbKClizEtafTKa/O1FPAGsNS2pihjrp7Td/sEyuhii4mHr7MKQigbwdXDyK3LhrtxpL87/32TiDL0ua1ZFRCywZkdNvwXyMSZNCLOJzVUYA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FA1pWKPh0iX+ELyufR4wQJU6p9DOsoxA4m37pT5g/QHVVzsS35Y8I8ktASJZ+oyU7EVw52g06h/lr/BxsFGRMC5YOhMxjFGiSPvXie4BlTHiGn1R/t8+BO10/YLcSkHo8dPc3IxXEF0SyogsTQUVKZoDtIRUrj19rrgUyntyGka0GQY+EW+VYFC6ibJzPB9fvDV8FxrcaA6fTUl11+jc2W9R2EoAuwE+13wNwZHyew2z1jwvQvZ3CqOuh1I08BhsUABXSbvRvFN+2WQJFwqhtx0/EgNs/XTbnsXvw1z8ROMRfdcJahItsnvIPV7VLU4YT+Qc+MfxAJx1QNp3+a+Y0g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: marmarek@xxxxxxxxxxxxxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Daniel Kiper <daniel.kiper@xxxxxxxxxx>
- Delivery-date: Thu, 30 Mar 2023 06:24:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29.03.2023 18:29, Roger Pau Monné wrote:
> On Mon, Dec 05, 2022 at 04:10:28PM +0100, Jan Beulich wrote:
>> On 23.11.2022 16:45, Roger Pau Monne wrote:
>>> @@ -265,6 +266,15 @@ __efi64_mb2_start:
>>> cmpl $MULTIBOOT2_TAG_TYPE_END,MB2_tag_type(%rcx)
>>> je .Lrun_bs
>>>
>>> + /*
>>> + * Get command line from Multiboot2 information.
>>> + * Must be last parsed tag.
>>
>> Why? And how do you guarantee this?
>
> I think the comment is misleading, must be the last checked for tag in
> the loop that does this in assembly, because it's not using cmove.
> I've adjusted to:
>
> /* Get command line from Multiboot2 information. */
> cmpl $MULTIBOOT2_TAG_TYPE_CMDLINE,MB2_tag_type(%rcx)
> jne .Lno_cmdline
> lea MB2_tag_string(%rcx),%rdx
> jmp .Lefi_mb2_next_tag
> .Lno_cmdline:
>
> Maybe there's some instruction I'm missing similar to a conditional
> lea?
There isn't. If you want to get away without conditional branch, then
you'll need to LEA to a scratch register (unconditional) and then
CMOVcc from that scratch register.
Jan
|
