[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/6] hw/isa/piix3: Reuse piix3_realize() in piix3_xen_realize()
- To: Bernhard Beschow <shentey@xxxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Thu, 30 Mar 2023 14:00:25 +0100
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: <qemu-devel@xxxxxxxxxx>, Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, David Woodhouse <dwmw@xxxxxxxxxxxx>, Hervé Poussineau <hpoussin@xxxxxxxxxxx>, Aurelien Jarno <aurelien@xxxxxxxxxxx>, Eduardo Habkost <eduardo@xxxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "Richard Henderson" <richard.henderson@xxxxxxxxxx>, Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>, Chuck Zmudzinski <brchuckz@xxxxxxx>
- Delivery-date: Thu, 30 Mar 2023 13:00:36 +0000
- Ironport-data: A9a23:5/dgu6g3MkyItm68BKVfqQRgX161fhcKZh0ujC45NGQN5FlHY01je htvWTvVP/zYM2XxfdB/bNux/R4CvJbXxoMwSAQ9rS48FSkb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWi0N8klgZmP6sT5wSGzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQbGBcxTTumm9nvnomECeBqoeQuFNPSadZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJYw1MYH49tL7Aan3XejtEqFWTtOwv7nLa1gBZ27nxKtvFPNeNQK25m27B/ jmZpz+jWEhy2Nq3+GC41yyOm9LzpDrlQ9hNJr6m7Ox3nwjGroAUIEJPDgbqyRWjsWa7QM53M UEY+iMy66M18SSDVcLhVhe1pHqFuB80WNdKFeA+rgaXxcL8+w+EAkAUQzgHb8Yp3OcmSDpv2 lKXktfBAT10rKbTWX+b7q2Trz65JW4SN2BqTSUeRgsY6NrxiIg0ilTESdMLOKetg8f8Az3Y3 zGApy94jLIW5eYR1q679ErLxTKhoJTEVBUy4C3TX2Ss9AQ/Y5SqD6Sw6Vnf6PpoKIefR0OG+ n8elKC26ekUBpyJ0iWVTugJFri04t6KNTTdhRhkGJxJ3yyn/HixfIZRyCtzKEdgLoAPfjqBS FTTtAVN6Y57M36jbKsxaIW0Y+wzwK39UNjoSP3QRtxJZJd3aUmA5i4GTUeNxW3pkUUquagiI 5qfKpzqC3sGYYxqwCe/Xesa+b8izCM53n+VQ53npzyrzr+BTHeQQKUCNh2FaaYk78usoB3S7 s1ENs2i0RhWW/H5eW/Q64F7ELwRBSFlX9as8ZURL7PdZFM8QwnNFsM935siS6tZvI9wityRo EqCGUZe73ryvWf+fFDihm9YVF//YXpuhStlYn19bQb0hyhLjZWHt/lGKcZuFVUz3Kk6lKMvE aFYEymVKq4XIgkr7QjxenUUQGZKUB2wzTyDMCO+CNTUV84xHleZkjMIk+aGycXvMsZUnZFky 1FY/lmHKafvviw7ZCosVNqhzkmqoV8Wk/9oUk3DL7F7IRu8qNEzd3Ku0K9pfangzCkvIBPAj 2565j9GzdQhXqdvqIWZ7Ux6h9zB/xRC8rpyQDCAsOfe2djy9Wu/245QONu1kcTmfDqsos2KP LwFp8wQxdVbxD6mRaIgSec0pU//jvOzz4JnIvNMRi+VNwz2Ues/fBFrH6Bn78Vw+1OQgiPuM mrnxzWQEezh1B/NeLLJGDcYUw==
- Ironport-hdrordr: A9a23:EiuXFq/ZlB0CewvI0xluk+DWI+orL9Y04lQ7vn2ZKCY4TiX8ra uTdZsguiMc5Ax+ZJhDo7C90di7IE80nKQdieN9AV7IZniEhILHFvAG0aLShxHmBi3i5qp8+M 5bAsxD4QTLfDpHsfo=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Sun, Mar 12, 2023 at 01:02:17PM +0100, Bernhard Beschow wrote:
> This is a preparational patch for the next one to make the following
> more obvious:
>
> First, pci_bus_irqs() is now called twice in case of Xen where the
> second call overrides the pci_set_irq_fn with the Xen variant.
pci_bus_irqs() does allocates pci_bus->irq_count, so the second call in
piix3_xen_realize() will leak `pci_bus->irq_count`. Could you look if
pci_bus_irqs_cleanup() can be called before the second pci_bus_irqs()
call, or maybe some other way to avoid the leak?
> Second, pci_bus_set_route_irq_fn() is now also called in Xen mode.
>
> Signed-off-by: Bernhard Beschow <shentey@xxxxxxxxx>
> Reviewed-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
Beside the leak which I think can happen only once, patch is fine:
Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Thanks,
--
Anthony PERARD
|
