[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/emul: Fix test harness build with blk.c moved out of x86_emulate.c
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 3 Apr 2023 14:32:09 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T85vDg5TUrhPHf2JrkJQCK2w9XzTQ/j04O5QemxmJV8=; b=C7xnCkHfZJJ96+a26QG3zWITD/wL8KM9sGutj7YrjnGDNmj3L2RhI0gwr/j9vwZFZxQ2ybTR18wyexJusYMDsjbYdO6v41Z621bnxAjn93R3ubnPtxCJPtoxIl7NlHfdmF+feXnl3oQCLz42dzBJgA7u1EX+oKHMOVnAZ4vKktOkX2WAZGsa1yJxuE6w8MmUdU5fi12v2+h3ryF7J0oSVmP5EY2wGo7hQz1TSHgpToEFPcUdZmx0vzvRgA+j2Z/46E3kCeem2vHg8qf9fs/3oZ81k8dELu/rW18mUaU1ufgD/y3uFQjrvOg5FwjnbX8t3ICK3n6wgMnZiJzNB5QzPA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OhK0du4NTETNhaiN/TwaYdavWbFHxsw9tKVF8toKz/I8u9V/YiUhhvjmm3oQHlj+Sz3XsLhQ1ZCZ7MhiftzotZ3ueRwHkakoUpwjL+aNTtekj0p9MtLjNFrLLHqV4XQuMDiZ1Ee3NGU9SqhlL4r9AgOIeMUtiwqG13kTEiYcBQVwbJjT3/r1MqPLB9DYpHNl4fL9ipOVXkdWo+SCKIXaNT0DZAnpsUtVZ2SiUdxEJ335oiYjjKnCGL1onXiQjij2xjec0uVaT6HJn24S8FYa3DeiIeQqbSqZaUMY7PO0z7kyzXClJNYDKfcmJc3R+47Ka1y8qnftSfOgL8u8fxAi9g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 03 Apr 2023 12:32:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 03.04.2023 14:25, Andrew Cooper wrote:
> Trying to build the test harness fails with:
>
> x86_emulate/blk.c: In function 'x86_emul_blk':
> x86_emulate/blk.c:74:15: error: expected ':' or ')' before 'ASM_FLAG_OUT'
> 74 | ASM_FLAG_OUT(, "; setz %[zf]")
> | ^~~~~~~~~~~~
>
> This is because ASM_FLAG_OUT() is still local to x86_emulate.c. Move it into
> x86-emulate.h instead so it ends up in all files including private.h. The
> main Xen build gets this macro from compiler.h.
>
> Fixes: c80243f94386 ("x86emul: move x86_emul_blk() to separate source file")
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Locally I actually have this exact same change, but in the MCOMMIT patch
(which predates the splitting work by quite a bit).
Jan
|
