[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 08/13] hw/xen: do not use aio_set_fd_handler(is_external=true) in xen_xenstore
- To: qemu-devel@xxxxxxxxxx
- From: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
- Date: Mon, 3 Apr 2023 14:29:59 -0400
- Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx>, Julia Suvorova <jusual@xxxxxxxxxx>, Stefan Hajnoczi <stefanha@xxxxxxxxxx>, Kevin Wolf <kwolf@xxxxxxxxxx>, Peter Lieven <pl@xxxxxxx>, Coiby Xu <Coiby.Xu@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Richard Henderson <richard.henderson@xxxxxxxxxx>, Stefano Garzarella <sgarzare@xxxxxxxxxx>, <qemu-block@xxxxxxxxxx>, Eduardo Habkost <eduardo@xxxxxxxxxxx>, Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, "Richard W.M. Jones" <rjones@xxxxxxxxxx>, "Dr. David Alan Gilbert" <dgilbert@xxxxxxxxxx>, Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>, Aarushi Mehta <mehta.aaru20@xxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Fam Zheng <fam@xxxxxxxxxx>, David Woodhouse <dwmw2@xxxxxxxxxxxxx>, Stefan Weil <sw@xxxxxxxxxxx>, Juan Quintela <quintela@xxxxxxxxxx>, Xie Yongji <xieyongji@xxxxxxxxxxxxx>, Hanna Reitz <hreitz@xxxxxxxxxx>, Ronnie Sahlberg <ronniesahlberg@xxxxxxxxx>, eesposit@xxxxxxxxxx, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Daniel P. Berrangé <berrange@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
- Delivery-date: Mon, 03 Apr 2023 18:30:39 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
There is no need to suspend activity between aio_disable_external() and
aio_enable_external(), which is mainly used for the block layer's drain
operation.
This is part of ongoing work to remove the aio_disable_external() API.
Signed-off-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
---
hw/i386/kvm/xen_xenstore.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/kvm/xen_xenstore.c b/hw/i386/kvm/xen_xenstore.c
index 900679af8a..6e81bc8791 100644
--- a/hw/i386/kvm/xen_xenstore.c
+++ b/hw/i386/kvm/xen_xenstore.c
@@ -133,7 +133,7 @@ static void xen_xenstore_realize(DeviceState *dev, Error
**errp)
error_setg(errp, "Xenstore evtchn port init failed");
return;
}
- aio_set_fd_handler(qemu_get_aio_context(), xen_be_evtchn_fd(s->eh), true,
+ aio_set_fd_handler(qemu_get_aio_context(), xen_be_evtchn_fd(s->eh), false,
xen_xenstore_event, NULL, NULL, NULL, s);
s->impl = xs_impl_create(xen_domid);
--
2.39.2
|