[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] x86emul/fuzzer: re-arrange cleaning
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 4 Apr 2023 08:37:16 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WCK7+KxNPVlBfCrlOenGmTflrOgFep/xixoemxsHHV8=; b=nPf/VyMWmsahspydfceckauCxIwnDIpDHn6ElcXJQrZhMj5ert2z8uS5NdY6moFrBLTS44eivQ85S5/BZp2/uINqnkbZUSaGXL4e8pgp6r5EecBDkMvquH6a7350NVShdCb9xAkAe7A7CQ3eopYfubJhk+4nZTfUFzVRJhJLP+vxBFhKJ6bXLDoTpC/U1vZzv0rjlPd7LzXH/EkcxbN8B/hYxNWJd1Odd4pRIfHNO1xp/p/4e6RY77suVJ2NSrwgaJiuHJMn1F4CE4SwLfT+5H88UzgPXJamP4OKQvKz1Ou+vZNd6E6DYEL8NyyQ2AqybF62seByNM9T2Y1K/3a+Ng==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kgiPZ83m5kwIHcBbRDEFp48bVUAOOTXKJlxGJP62hYe0uFNRjUzi8SuyN/Wdfp+Ky85EbnKQ8yrRWKZrVRek2Y9EEPaYEm9siYtbUL4MfYgiiUlPrByZzNBOcvzgDS1T7hjv712sn6LMOBeqNsHHWklKwiOhjufT0ELARwpkoI27D4GhnWiZFeQdUStKyVaNVNsZchdH/bIpV9Z3kKgZoE0LUGq5/+fLUF0uYpLLMsMrrjEzfTGZnmDvrSV8aJeidc83nTOlybt6uSs7IjLsMpckYBrzyjQeDb7C3sOm/mc00VAhDcLwRN2sTbb+q19DkT2WwN/aVQwb3ep2QjwXXw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
- Delivery-date: Tue, 04 Apr 2023 06:37:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
The latter of the two commits referenced below converted x86_emulate
from a symlinked dir to a real one, holding symlinked files. Yet even
before that the split between distclean and clean was suspicious: A
similar split, removing symlinks only in distclean, doesn't exist
anywhere else in the tree afaics.
Fixes: c808475882ef ("tools/fuzz: introduce x86 instruction emulator target")
Fixes: 9ace97ab9b87 ("x86emul: split off opcode 0f01 handling")
Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
---
The use of FORCE also looks suspicious to me in the rules creating the
symlinks. Supposedly that's to deal with the source tree moving, but is
that really something we need to care about (and if so, here but not
elsewhere)?
--- a/tools/fuzz/x86_instruction_emulator/Makefile
+++ b/tools/fuzz/x86_instruction_emulator/Makefile
@@ -60,11 +60,11 @@ all: x86-insn-fuzz-all
.PHONY: distclean
distclean: clean
- rm -f x86_emulate x86-emulate.c x86-emulate.h wrappers.c cpuid.c
.PHONY: clean
clean:
rm -f *.a *.o $(DEPS_RM) afl-harness afl-harness-cov *.gcda *.gcno
*.gcov
+ rm -rf x86_emulate x86-emulate.c x86-emulate.h wrappers.c cpuid.c
.PHONY: install
install: all
|
