[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 14/15] libx86: Update library API for cpu_policy


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 4 Apr 2023 17:34:42 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NRzzlFeZvhJduDLPey9wLw9oUPxcwz4PaBTrfAGQoHo=; b=KA1Gj/WIN4MpPqxc9EGHSvWjIHj0nSHXgrEQk9B6D6utC+ZMch52xdmB8FRuEY6aw5MCNfap8OsaKZ5Z57hXlvkroi+MOBlwM2elSTWxeyGl+awUHzUzjppJX5wcoBACYUbUuVwD1lxjmrDbXT0bwVe2ae/TGUYAfDm1bXGh1VvcG3V+2NUoysZwwTmdMdrg6pQb2T+UY8J0XoaCsqq/gI9gjl47D0EJr1KZL5vxd+6Fxbu6ygFMecotaa1vz1zZtFzWEFyg+It/hp7/fa/UT6qLBM4xEmQxGdXOjIMJ+CO0GuWslv7S6u4dNyHCkFqOi8MQPHhU+JD+c8R1gKIGpg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d4AjKKNXb1SxKoopU6MW4HnYpWop+Jz54Cx1kNOZVQswfYc8CyVCNYGu/FH+yvr032csE94MXGzMFk8Wypan//TpGcBib1ZVPd4qlgiiq0wgq341fhcA35tC6ONvhHM3owu5eNmArGW0YI53w+qNWcsaQ6XiLe7+EzH8ms2KkstSIABei/8ItT1eDm4/CrZm02TQKDo44Aeh91droynZbes9vsb4264tAea2YzURP7NLPrKQcHbN+YE1lHcWf+/Fm7AgA/UvjGDLnRyYLlYld/QeDXhBoHIx2AITxOawc7eKg0JVCXfRNWVRHv51QhZNKKZ5gF6XY1phgP4dtUmNwQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 04 Apr 2023 15:35:03 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 04.04.2023 11:52, Andrew Cooper wrote:
> Adjust the API and comments appropriately.
> 
> x86_cpu_policy_fill_native() will eventually contain MSR reads, but leave a
> TODO in the short term.

That'll then require passing in a callback function anyway, such that
different environments can use different ways of getting at the wanted
MSR values. (IOW a bigger change anyway.)

> No practical change.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

What about x86_cpuid_lookup_deep_deps()? That'll be looking at more than
just CPUID bits as well, won't it?

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.