[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH] hw/xen: Fix memory leak in libxenstore_open() for Xen
On Tue, 4 Apr 2023 at 19:25, David Woodhouse <dwmw2@xxxxxxxxxxxxx> wrote: > > From: David Woodhouse <dwmw@xxxxxxxxxxxx> > > There was a superfluous allocation of the XS handle, leading to it > being leaked on both the error path and the success path (where it gets > allocated again). > > Spotted by Coverity (CID 1508098). > > Fixes: ba2a92db1ff6 ("hw/xen: Add xenstore operations to allow redirection to > internal emulation") > Suggested-by: Peter Maydell <peter.maydell@xxxxxxxxxx> > Signed-off-by: David Woodhouse <dwmw@xxxxxxxxxxxx> > --- > hw/xen/xen-operations.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/xen/xen-operations.c b/hw/xen/xen-operations.c > index 4b78fbf4bd..3d213d28df 100644 > --- a/hw/xen/xen-operations.c > +++ b/hw/xen/xen-operations.c > @@ -287,7 +287,7 @@ static void watch_event(void *opaque) > static struct qemu_xs_handle *libxenstore_open(void) > { > struct xs_handle *xsh = xs_open(0); > - struct qemu_xs_handle *h = g_new0(struct qemu_xs_handle, 1); > + struct qemu_xs_handle *h; > > if (!xsh) { > return NULL; > -- > 2.34.1 Reviewed-by: Peter Maydell <peter.maydell@xxxxxxxxxx> thanks -- PMM
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |